Skip to content

quiche: Add PMTU path event - #2721

Merged
ghedo merged 1 commit into
cloudflare:masterfrom
kkelkar:kaustubh/pmtu-path-event
Sep 17, 2026
Merged

ghedo merged 1 commit into
cloudflare:masterfrom
kkelkar:kaustubh/pmtu-path-event

Conversation

@kkelkar

@kkelkar kkelkar commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Notify applications when PMTU discovery changes the validated packet size limit for a network path.

@kkelkar
kkelkar requested a review from a team as a code owner September 10, 2026 13:43
@kkelkar
kkelkar force-pushed the kaustubh/pmtu-path-event branch 2 times, most recently from 0e453c6 to 49c4fe2 Compare September 15, 2026 14:51
@kkelkar
kkelkar marked this pull request as draft September 15, 2026 14:55
@kkelkar
kkelkar force-pushed the kaustubh/pmtu-path-event branch from 49c4fe2 to d82497f Compare September 15, 2026 16:39
@kkelkar
kkelkar marked this pull request as ready for review September 15, 2026 16:40
@kkelkar kkelkar changed the title Add PMTU path event quiche: Add PMTU path event Sep 15, 2026
Comment thread quiche/src/lib.rs Outdated
@kkelkar
kkelkar force-pushed the kaustubh/pmtu-path-event branch from d82497f to fb97b2f Compare September 15, 2026 16:59
@kkelkar
kkelkar requested a review from ghedo September 15, 2026 17:28
@ghedo
ghedo enabled auto-merge (squash) September 16, 2026 09:38
@ghedo

ghedo commented Sep 16, 2026

Copy link
Copy Markdown
Member

/bonk

@ask-bonk

ask-bonk Bot commented Sep 16, 2026

Copy link
Copy Markdown

LGTM!

github run

@ghedo
ghedo disabled auto-merge September 16, 2026 10:08
Comment thread quiche/src/path.rs Outdated
Comment thread quiche/src/path.rs Outdated
Comment thread quiche/src/lib.rs Outdated
Comment thread quiche/src/tests.rs Outdated
Comment thread quiche/src/lib.rs

@ghedo ghedo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments to suggest some simplifications, but lgtm overall.

@kkelkar
kkelkar force-pushed the kaustubh/pmtu-path-event branch from fb97b2f to 0445ed5 Compare September 16, 2026 10:37
Comment thread quiche/src/path.rs
Comment thread quiche/src/lib.rs

@jrouviere jrouviere left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

    Notify applications when PMTU discovery changes the validated packet size
    limit for a network path.
@kkelkar
kkelkar force-pushed the kaustubh/pmtu-path-event branch from 0445ed5 to 14a5d5e Compare September 17, 2026 08:51
@ghedo
ghedo enabled auto-merge (squash) September 17, 2026 09:01
@ghedo
ghedo merged commit 5f00e83 into cloudflare:master Sep 17, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants