test(css): css module compatibility issue and workaround verification - #3000
Open
NriotHrreion wants to merge 4 commits into
Open
test(css): css module compatibility issue and workaround verification#3000NriotHrreion wants to merge 4 commits into
NriotHrreion wants to merge 4 commits into
Conversation
commit: |
Contributor
Performance benchmarksCompared 0 improved · 0 regressed · 6 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
NriotHrreion
marked this pull request as ready for review
August 19, 2026 14:17
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e397350718
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2992
Overview
see #2992 (comment)
There are some css module compatibility issues between postcss and vite, which has been solved by a vite plugin https://github.com/privatenumber/vite-css-modules. For vinext, we need to verify the
vite-css-modulesplugin could resolve the compatibility issue completely, and recommend users to installvite-css-modulesplugin duringvinext init.What changed
vite-css-modulesVerification
css-module-compatibilityandcss-module-compatibility-fixedpnpm test tests/css-module-compatibility.test.ts