Skip to content

fix(build): keep CDN warm discovery route-correct - #3033

Closed
james-elicx wants to merge 1 commit into
codex/rsc-prewarm-loading-shell-scopefrom
codex/rsc-prewarm-discovery-correctness
Closed

fix(build): keep CDN warm discovery route-correct#3033
james-elicx wants to merge 1 commit into
codex/rsc-prewarm-loading-shell-scopefrom
codex/rsc-prewarm-discovery-correctness

Conversation

@james-elicx

Copy link
Copy Markdown
Member

Stacked on #3032.

Summary

  • discover normal static child routes whose params are generated by a parent layout
  • exclude configured-rewrite public paths from both HTML and canonical RSC warming
  • preserve that exclusion when optional locally-prerendered fallback shells are included
  • evaluate rewrite sources against the actual trailing-slash warm URL and every configured domain default locale

Scope

Only changes the deploy warm plan. It does not execute rewrites during discovery, locally render pages, alter runtime routing, or expand the deferred special RSC variants.

Validation

  • 149 focused discovery, prerender, and Cloudflare warm-plan tests
  • targeted vp check on all 6 touched files
  • vp run vinext#build
  • vp run @vinext/cloudflare#build

@pkg-pr-new

pkg-pr-new Bot commented Aug 22, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@vinext/cloudflare@3033
npm i https://pkg.pr.new/create-vinext-app@3033
npm i https://pkg.pr.new/@vinext/types@3033
npm i https://pkg.pr.new/vinext@3033

commit: f482a97

@github-actions

Copy link
Copy Markdown
Contributor
Example Preview Production Original
app-router-cloudflare preview production
pages-router-cloudflare preview production
app-router-playground preview production original
realworld-api-rest preview production
nextra-docs-template preview production
benchmarks preview production
hackernews preview production original
workers-cache preview production
web preview production

@github-actions

Copy link
Copy Markdown
Contributor

Performance benchmarks

Compared f482a97 against base 1bd9043 using alternating same-runner rounds. Next.js was unchanged and skipped.

0 improved · 0 regressed · 6 within ±1.5%

Scenario Framework Baseline Current Change
Client bundle size (gzip) vinext 142.2 KB 142.2 KB ⚫ -0.0%
Client entry size (gzip) vinext 129.5 KB 129.5 KB ⚫ -0.0%
Dev server cold start vinext 2.48 s 2.46 s ⚫ -1.0%
Production build time vinext 2.66 s 2.66 s ⚫ +0.1%
RSC entry closure size (gzip) vinext 116.0 KB 116.0 KB ⚫ -0.0%
Server bundle size (gzip) vinext 197.5 KB 197.5 KB ⚫ -0.0%

View detailed results and traces

🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head

@james-elicx

Copy link
Copy Markdown
Member Author

Superseded by consolidated PR #3040. No commits were dropped or rewritten: #3040 now contains this exact linear commit as part of #3021#3040. Closing only the redundant draft PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant