Skip to content

fix(cloudflare): preserve staged CDN warmup guarantees - #3036

Closed
james-elicx wants to merge 1 commit into
codex/rsc-prewarm-deploy-route-targetsfrom
codex/rsc-prewarm-deploy-state-correctness
Closed

fix(cloudflare): preserve staged CDN warmup guarantees#3036
james-elicx wants to merge 1 commit into
codex/rsc-prewarm-deploy-route-targetsfrom
codex/rsc-prewarm-deploy-state-correctness

Conversation

@james-elicx

Copy link
Copy Markdown
Member

Summary

  • fail deployment when Wrangler deployment status cannot be read instead of silently promoting before warmup
  • prefer a concrete custom domain or catch-all Worker route over workers.dev when Wrangler reports both
  • derive the version-override Worker name from Wrangler's successful upload output, avoiding TPR config-parser limitations (including valid single-quoted TOML)

This is stacked on #3035 and only addresses deploy-state findings from the fresh cumulative RSC prewarming review. TPR remains unchanged.

Validation

  • vp test run tests/cloudflare-version-deploy.test.ts tests/cloudflare-cdn-warm-deploy.test.ts tests/deploy.test.ts (368 passed)
  • targeted vp check for all six touched files
  • vp run vinext#build
  • vp run @vinext/cloudflare#build

@pkg-pr-new

pkg-pr-new Bot commented Aug 22, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@vinext/cloudflare@3036
npm i https://pkg.pr.new/create-vinext-app@3036
npm i https://pkg.pr.new/@vinext/types@3036
npm i https://pkg.pr.new/vinext@3036

commit: ae692e1

@github-actions

Copy link
Copy Markdown
Contributor
Example Preview Production Original
app-router-cloudflare preview production
pages-router-cloudflare preview production
app-router-playground preview production original
realworld-api-rest preview production
nextra-docs-template preview production
benchmarks preview production
hackernews preview production original
workers-cache preview production
web preview production

@github-actions

Copy link
Copy Markdown
Contributor

Performance benchmarks

Compared ae692e1 against base 58e25d2 using alternating same-runner rounds. Next.js was unchanged and skipped.

0 improved · 0 regressed · 6 within ±1.5%

Scenario Framework Baseline Current Change
Client bundle size (gzip) vinext 142.2 KB 142.2 KB ⚫ 0.0%
Client entry size (gzip) vinext 129.5 KB 129.5 KB ⚫ -0.0%
Dev server cold start vinext 3.01 s 2.99 s ⚫ -0.6%
Production build time vinext 3.27 s 3.26 s ⚫ -0.4%
RSC entry closure size (gzip) vinext 116.0 KB 116.0 KB ⚫ -0.0%
Server bundle size (gzip) vinext 197.5 KB 197.5 KB ⚫ -0.0%

View detailed results and traces

🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head

@james-elicx

Copy link
Copy Markdown
Member Author

Superseded by consolidated PR #3040. No commits were dropped or rewritten: #3040 now contains this exact linear commit as part of #3021#3040. Closing only the redundant draft PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant