Skip to content

fix(cloudflare): reject incomplete no-promote CDN warmup - #3042

Closed
james-elicx wants to merge 1 commit into
codex/rsc-prewarm-pages-deployed-prooffrom
codex/rsc-prewarm-no-promote-complete
Closed

fix(cloudflare): reject incomplete no-promote CDN warmup#3042
james-elicx wants to merge 1 commit into
codex/rsc-prewarm-pages-deployed-prooffrom
codex/rsc-prewarm-no-promote-complete

Conversation

@james-elicx

Copy link
Copy Markdown
Member

Summary

  • reject --warm-cdn-no-promote when any staged warm request remains unsuccessful
  • keep the uploaded version staged at 0% and report the existing cleanup guidance instead of returning false success
  • cover readiness-success plus real-request-failure without promoting

Scope

This is a focused follow-up from the cumulative RSC/ISR CDN prewarming review. It changes only no-promote completion semantics and its focused deploy test.

Validation

  • 26 Cloudflare warm-deploy tests passed
  • targeted format, lint, and type checks passed

@pkg-pr-new

pkg-pr-new Bot commented Aug 22, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@vinext/cloudflare@3042
npm i https://pkg.pr.new/create-vinext-app@3042
npm i https://pkg.pr.new/@vinext/types@3042
npm i https://pkg.pr.new/vinext@3042

commit: ff55d3f

@github-actions

Copy link
Copy Markdown
Contributor

Performance benchmarks

Compared ff55d3f against base e8079d2 using alternating same-runner rounds. Next.js was unchanged and skipped.

1 improved · 0 regressed · 5 within ±1.5%

Scenario Framework Baseline Current Change
Client bundle size (gzip) vinext 142.2 KB 142.2 KB ⚫ +0.0%
Client entry size (gzip) vinext 129.5 KB 129.5 KB ⚫ +0.0%
Dev server cold start vinext 3.05 s 3.00 s 🟢 -1.6%
Production build time vinext 3.31 s 3.29 s ⚫ -0.7%
RSC entry closure size (gzip) vinext 116.0 KB 116.0 KB ⚫ -0.0%
Server bundle size (gzip) vinext 197.5 KB 197.5 KB ⚫ -0.0%

View detailed results and traces

🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head

@james-elicx

Copy link
Copy Markdown
Member Author

Superseded by consolidated PR #3046. No commits were dropped or rewritten: #3046 now contains this exact linear commit as part of #3041#3046. Closing only the redundant draft PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant