WC-6046 simplify preview onboarding - #15748
podonnell-dev wants to merge 4 commits into
Conversation
🦋 Changeset detectedLatest commit: 214e46a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| placement: config.placement, | ||
| cache: config.cache, | ||
| containers: config.containers, | ||
| tail_consumers: config.tail_consumers, |
There was a problem hiding this comment.
assemblePreviewScriptSettings() only sends the tail consumer service name to the Preview API, so an environment copied into this generated snippet is silently ignored. Since it is redacted, this also blocks the user until they replace a value that cannot affect the Preview. Exclude it while deriving the suggested Preview configuration.
| tail_consumers: config.tail_consumers, | |
| tail_consumers: config.tail_consumers?.map(({ service }) => ({ service })), |
There was a problem hiding this comment.
generally a hidden field based on docs. silently omitted here is okay for now, but needs to be revisited
https://developers.cloudflare.com/workers/observability/logs/tail-workers/
https://developers.cloudflare.com/workers/wrangler/configuration/#non-inheritable-keys
|
I'm Bonk, and I've done a quick review of your PR. Simplifies Preview onboarding and centralizes binding/config proposal handling.
|
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
@cloudflare/containers-shared
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
Fixes WC-6046.
Simplifying preview onboarding logic, which covers the printing of a suggest previews block based on the user's current wrangler configuration file or dashboard settings. Reduced our process to a few principles
d1.database_idvsd1.id(deprecated)placement.modeandr2_buckets.jurisdiction)A picture of a cute animal (not mandatory, but encouraged)