Add SHA-384 support to file checksum computation (FIPS+NCS) - #267
Open
vkalapov wants to merge 1 commit into
Open
Add SHA-384 support to file checksum computation (FIPS+NCS)#267vkalapov wants to merge 1 commit into
vkalapov wants to merge 1 commit into
Conversation
LMCROSSITXSADEPLOY-3224
vkalapov
force-pushed
the
fips-file-digest-sha256
branch
from
July 28, 2026 08:43
ec08ad6 to
505e9f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
SHA384/SHA-384cases toComputeFileChecksuminutil/digest.go, and also handle the hyphenatedSHA-256variant while here.Why
The deploy service now stores file digests with SHA-384 (
DIGEST_ALGORITHM = "SHA-384") to satisfy FIPS 140-3 and NCS MODERATE requirements. The CLI callsGET /filesand uses thedigestAlgorithmfield returned per entry to compute a local digest for skip-upload optimisation. Without this change, old CLI hits thedefaultbranch and prints"Unsupported digest algorithm \"SHA-384\"", causing a re-upload on every retry instead of skipping.Deploys still succeed without this fix (the server never verifies a client-sent digest), but the skip optimisation is degraded.
LMCROSSITXSADEPLOY-3224