feat(authz): add shoot-grafter group to authz RBAC and matchConditions - #2129
Open
Zaggy21 wants to merge 1 commit into
Open
feat(authz): add shoot-grafter group to authz RBAC and matchConditions#2129Zaggy21 wants to merge 1 commit into
Zaggy21 wants to merge 1 commit into
Conversation
3 tasks
On-behalf-of: @SAP krzysztof.zagorski@sap.com Signed-off-by: Zaggy21 <k.zaggy@gmail.com>
Zaggy21
force-pushed
the
feat/authz-shoot-grafter-rbac
branch
from
August 7, 2026 01:01
e3fe48b to
3bd26a3
Compare
Zaggy21
marked this pull request as ready for review
August 7, 2026 01:03
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the authz webhook’s interception and read-permissions so it can authorize shoot-grafter.cloudoperators.dev resources (in addition to greenhouse.sap) by updating the dev-env AuthorizationConfiguration matchConditions and the authz chart’s RBAC.
Changes:
- Updated
matchConditionsto route requests for bothgreenhouse.sapandshoot-grafter.cloudoperators.devAPI groups to the authz webhook (secure + insecure dev env configs). - Extended the authz webhook ServiceAccount ClusterRole permissions to include the
shoot-grafter.cloudoperators.devAPI group.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dev-env/webhook/structured-authz-secure.yaml | Adds shoot-grafter.cloudoperators.dev to the webhook matchConditions API group filter. |
| dev-env/webhook/structured-authz-insecure.yaml | Adds shoot-grafter.cloudoperators.dev to the webhook matchConditions API group filter. |
| charts/authz/templates/rbac.yaml | Extends ClusterRole apiGroups to allow read access (get/list/watch) for shoot-grafter.cloudoperators.dev. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extends the authz webhook to also intercept
shoot-grafter.cloudoperators.devresources by adding the API group to the authz chart RBAC and to the matchConditions in the AuthorizationConfiguration dev-env files.What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist