fix(ui): fix rules of hooks violations via useId - #1872
Draft
franzheidl wants to merge 2 commits into
Draft
Conversation
Signed-off-by: Franz Heidl <franz.heidl@sap.com>
|
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-- WIP UNTESTED, DO NOT MERGE --
Summary
Fix all
useId-related violations of Rules of Hooks: Call hooks only on top levelChanges Made
uniqueId()wrapper with two top-level callsgeneratedName = useId()andgeneratedId = useId(); used inline ingroupNameandgroupIdassignmentsgeneratedId = useId()to top level; split off from the conditionaltheIdassignment;helptextIdwas already unconditional so unchangeduseId()calls forgeneratedNameandgeneratedIduniqueIdarrow function; replaced with top-levelgeneratedId = useId()used intheIdassignmentuniqueIdarrow function; replaced with top-levelgeneratedId = useId()used intheIdassignment;helptextIdwas already unconditional so unchangedgenerateUniqueIdarrow function; replaced with top-levelgeneratedId = useId(); introducedtheIdcombiningidandgeneratedId; updatedidandhtmlForusages in JSX fromgeneratedIdtotheIduniqueIdarrow function; replaced with top-levelgeneratedId = useId()used intheIdassignmentuniqueIdarrow function; replaced with top-levelgeneratedId = useId()used intheIdassignmentRelated Issues
Closes #1589
Testing Instructions
pnpm ipnpm run testChecklist
PR Manifesto
Review the PR Manifesto for best practises.