fix: Default max_row_group_length to a row count so parquet files split into row groups - #772
Merged
Merged
Conversation
WithMaxRowGroupLength takes a number of rows, but the default was 128 * 1024 * 1024, a byte-shaped value that made every written parquet file a single row group. Default is now 1024 * 1024 rows.
erezrokah
marked this pull request as ready for review
September 10, 2026 11:45
erezrokah
requested review from
disq and
murarustefaan
and removed request for
a team and
murarustefaan
September 10, 2026 11:45
disq
approved these changes
Sep 10, 2026
kodiakhq Bot
pushed a commit
that referenced
this pull request
Sep 10, 2026
🤖 I have created a release *beep* *boop* --- ## [4.7.4](v4.7.3...v4.7.4) (2026-09-10) ### Bug Fixes * Default max_row_group_length to a row count so parquet files split into row groups ([#772](#772)) ([be761d3](be761d3)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.96.1 ([#764](#764)) ([c5bee4d](c5bee4d)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.96.2 ([#766](#766)) ([4589542](4589542)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.96.3 ([#771](#771)) ([ae57693](ae57693)) * **deps:** Update module github.com/stretchr/testify to v1.12.1 ([#769](#769)) ([3ff2c75](3ff2c75)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets the
max_row_group_lengthdefault to 1048576 rows instead of the byte-shaped 134217728, which made every parquet file we write a single row group, and documents the unit in the spec and JSON schema.Fixes https://linear.app/env-zero/issue/ATH-702