fix: substitute CLOUDSCALE_API_TOKEN when deploying CAPCS manually - #65
Open
alakae wants to merge 2 commits into
Open
fix: substitute CLOUDSCALE_API_TOKEN when deploying CAPCS manually#65alakae wants to merge 2 commits into
alakae wants to merge 2 commits into
Conversation
`make deploy` applied config/manager/credentials.yaml verbatim, so without
clusterctl init's or Tilt's separate substitution mechanisms the manager's
own credentials Secret got the literal `${CLOUDSCALE_API_TOKEN}` placeholder
as its token, causing a CrashLoopBackOff with an "Invalid token" error from
the cloudscale API.
Pipe the built manifest through `envsubst` scoped to just that one variable
(not a bare envsubst, to avoid touching any other `$identifier`-shaped
content in the generated CRDs).
Set up specific Makefile targets (and documentation) to support quick local checks without the need of tilt. Removes existing deploy/install/etc. targets which come with kubebuilder boilerplate but we never use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents a plain-kind deploy path in docs/development.md. This was handier for me than bringing up Tilt for a quick manual check of a local image.