porch: make gate artifact auto-open configurable#1231
Conversation
Architect Integration ReviewRisk: High — 1,654 additions across 21 files, touching Porch orchestration and Agent Farm worktree setup. Three-way integration review (Gemini, Codex, Claude) returned unanimous APPROVE with high confidence and no key issues. I independently reviewed the producer guard, config precedence, snapshot/setup paths, tests, documentation, and governance updates. The design fits the architecture: Local verification passed:
Before the Porch PR gate is approved, please include the remaining untracked project protocol artifacts under No implementation changes requested. Architect integration review |
…ged by a maintainer; contributor delivery ends with an open PR per the specification
Summary
Adds
porch.autoOpenArtifactsas a backward-compatible, producer-side opt-out for Porch's automatic specification, plan, and review artifact opens. Setting it tofalseprevents Porch from invokingafx openwhile preserving gate state, artifact output, approval instructions, manual file opens, and Tower's normal tab-focus behavior.Agent Farm also propagates the main workspace's personal
.codev/config.local.jsonpreference into builders as an atomically refreshed regular-file snapshot, avoiding write-through mutation of the main personal configuration.Closes #1216
Changes
porch.autoOpenArtifactsconfiguration key; unset andtruepreserve existing behavior, while explicitfalsesuppresses the automaticafx openchild process..codev/config.local.jsoninto builder worktrees during both spawn paths andafx setup, refreshing it before post-spawn hooks without using a symlink or deleting builder-local preferences when the main source is absent.tower-utils.test.ts’sHOMEso developer-global architect-harness configuration cannot affect Agent Farm/Tower default-harness assertions.Testing
@cluesmith/codevVitest suite: 3,638 passed, 48 existing skips, 0 failed.pnpm build: passed.afx openstill created and focused the expected file tab.Spec
Link:
codev/specs/1216-configurable-porch-gate-artifact-auto-open.mdReview
Link:
codev/reviews/1216-configurable-porch-gate-artifact-auto-open.md