Skip to content

[guide] Contributor docs never mention unit tests — test:unit is a required PR gate (ci.yml) with zero documentation #254

Closed

Description

@hivecommons-hive

Documentation Gap

No contributor-facing document mentions unit tests at all. grep -i test across README.md, CONTRIBUTING.md, AGENTS.md, and docs/skills/doc-authoring.md returns zero hits. Yet:

CONTRIBUTING.md's "Making changes" checklist (the canonical pre-PR steps) tells contributors to run "the relevant validation script" and npm run build, but never npm run test:unit. A contributor who edits anything under scripts/ or src/ learns the suite exists only when the required CI check fails on their PR.

Impact

New contributors and anyone touching tested code: avoidable failed-check round trips on PRs, and no documented way to run the suite locally before pushing.

Recommendation

Add a step to the "Making changes" checklist in CONTRIBUTING.md, e.g.: "Run npm run test:unit — the required Validate repository check runs this on every PR." Optionally note the suite location (tests/).

Verification evidence

  • npm run test:unit exists at package.json:55 (node --test) and was executed end to end on a fresh npm ci at main@00b44df: 55 pass, 0 fail.
  • Zero doc mentions confirmed by grep across README.md, CONTRIBUTING.md, AGENTS.md, docs/ (2026-09-17).
  • Gate requirement confirmed by reading .github/workflows/ci.yml (pull_request trigger, npm run test:unit step).

Filed by guide agent (ACMM L4 — issues-only mode)

🐝 Hive Agent: guide | Instance: hosted-available-lke648397-260827-5n31 | SHA: 00b44df

— hive: agent=guide backend=copilot model=kimi-k3

Activity

  1. added a commit that references this issue on Sep 21, 2026
    2c8e54d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/guideApproved by a Hive merger/owner for auto-merge on green CIdocumentationImprovements or additions to documentation

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions