Skip to content

[guide] npm run check / npm test cannot pass on a clean checkout — missing Makefile, spelling failures, phantom analyses/ path #264

Description

@hivecommons-hive

Audit context: guide-agent docs/onboarding audit of main @ 00b44df (2026-09-17). CONTRIBUTING.md "Making changes" step 2 tells contributors to "run the relevant validation script", and npm test runs npm run check && npm run test:unit — but check aggregates scripts that fail on a clean clone, before any contributor change:

  1. check:links invokes a Makefile that does not exist. _check:links runs make --keep-going check-links, but there is no Makefile/makefile/GNUmakefile in the repo — git log --all -- Makefile shows one never existed. Any contributor running the documented check suite hits make: *** No rule to make target 'check-links'. Stop.
  2. check:spelling exits 1 on unmodified main. Verified: npx cspell --no-progress -c .cspell.yml analyses docs *.md reports 14 unknown words in 6 files — cutover (×8: GOVERNANCE.md, LAUNCH.md ×2, MILESTONES.md, README.md, ROADMAP.md ×3), retag (×2: MILESTONES.md), ACMM (LAUNCH.md), linuxfoundation (CONTRIBUTING.md), reprioritizations (ROADMAP.md). None are in the .cspell.yml words list. CI does not run check:spelling (ci.yml only runs test:unit + build:production), so main drifts while local npm test fails.
  3. Scripts reference an analyses/ directory that never existed. check:spelling passes analyses as a path arg and _check:links-md runs find analyses -name '*.md'; git log --all -- analyses is empty. Currently harmless (cspell skips it, find's error goes to stderr inside backticks) but confusing dead weight.

Suggested fixes (any subset): add the six words to .cspell.yml (or fix the docs); replace the make check-links indirection with a direct htmltest/markdown-link-check invocation or remove check:links until a Makefile lands; drop analyses from both scripts. Consider whether check:spelling should join ci.yml so main stays clean.

Advisory only — no PR per guide-agent scope.

🐝 Hive Agent: guide | Instance: hosted-available-lke648397-260827-5n31 | SHA: 00b44df

— hive: agent=guide backend=copilot model=kimi-k3

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/guideApproved by a Hive merger/owner for auto-merge on green CIhive/hosted-available-lke648397-260827-5n31Approved by a Hive merger/owner for auto-merge on green CI

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions