[scanner] main is RED: merged #334 breaks validate-architectures tests, Deploy to GitHub Pages now fails at 'Run unit tests' — production deploy blocked

[hivecommons-hive]

Finding

Today's merge wave (20 PRs, 00b44df..49736c0) landed #334 ([sec-check] fix: validate architecture catalog sourceUrl scheme and asset containment), which added an https-scheme requirement for sourceUrl in scripts/validate-architectures.mjs — but did not update the pre-existing fixture in tests/validate-architectures.test.mjs, whose validRecord (acme-platform) has no sourceUrl field at all.

Main @ 49736c0 therefore has 2 failing unit tests, reproduced locally on a clean checkout:

✖ accepts a valid catalog — AssertionError: 1 error(s) in architecture catalog:
    [error] acme-platform: sourceUrl must be an https URL; it is rendered as an href in the member directory  (1 !== 0)
✖ accepts records without an assets array — same error (tests/validate-architectures.test.mjs:24 and :59)

Impact

Deploy run 35610128891 for HEAD 49736c0 failed at the build / Run unit tests step (exit 1) and the deploy job was skipped. The production site cannot deploy until this is fixed. Two earlier deploy runs in the same push batch were cancelled.

This is the exact failure mode #357 predicted: ci.yml's Validate repository check is not required, so PR #334 merged with a red unit suite. (The new Run unit tests step in deploy-gh-pages.yml did its job — it caught the break before a bad deploy; the gap is that nothing blocked the merge.)

Recommendation

One-line-class fix: add a valid https sourceUrl (e.g. sourceUrl: 'https://example.com/acme-platform') to the validRecord fixture in tests/validate-architectures.test.mjs (and any other fixture record in that file that asserts exit 0). Then re-run the deploy. Separately, #357 (require the ci.yml check) remains the systemic fix — this incident is its proof case.

---

Filed by scanner agent (ACMM L4 — issues-only mode)

🐝 Hive Agent: scanner | Instance: hosted-available-lke648397-260827-5n31 | SHA: 49736c0

— hive: agent=scanner backend=copilot model=kimi-k3

[hivecommons-hive]

Streak update: every deploy since the 14:07Z wave start has failed at Run unit tests — 35610128891 (49736c0), 35611363542 (31ccbc7), 35611964907 (31c8f2b), 35614114220 (0f0ee41), 35614118228 (60ddab0). Five consecutive red deploys; the merge wave is continuing to land PRs on a red main. The one-line fixture fix (add sourceUrl: 'https://…' to validRecord in tests/validate-architectures.test.mjs) unblocks all of them. — scanner agent

🐝 Hive Agent: scanner | Instance: hosted-available-lke648397-260827-5n31 | SHA: 60ddab0

— hive: agent=scanner backend=copilot model=kimi-k3

[hivecommons-hive]

Re-verified on main @ 678e427: the breakage appears resolved.

• node --test tests/validate-architectures.test.mjs → pass 15, fail 0 (the sourceUrl fixture errors are gone)
• npm run validate:architecture-assets → exit 0 (1 benign foreignObject warning)

A later merge in the wave fixed the fixture. Recommend closing this issue; #357 (make the ci.yml check required) remains the systemic fix.

— scanner agent (reap pass)

🐝 Hive Agent: scanner | Instance: hosted-available-lke648397-260827-5n31 | SHA: unknown

— hive: agent=scanner backend=copilot model=kimi-k3

[hivecommons-hive]

Verified resolved @ 0fd5f8b: tests/validate-architectures.test.mjs fixture now carries a valid https sourceUrl, the full unit suite passes on a clean checkout (596 tests, 594 pass / 0 fail / 2 todo), and the last three deploy-gh-pages runs (incl. HEAD 0fd5f8b at 2026-09-21T21:34Z) are green. This can be closed; #357 (require the ci.yml check) remains the systemic follow-up. — scanner

🐝 Hive Agent: scanner | Instance: hosted-available-lke648397-260827-5n31 | SHA: unknown

— hive: agent=scanner backend=copilot model=kimi-k3