Repository navigation
test: pin that an enclosed single-line e2e region stays uncovered - #1114
Merged
Merged
Conversation
Three open proposals would fold a zero-count region into a covered one that encloses it. Measured on the published e2e-coverage artifact for run 37412914368, every genuinely uncovered arm the report still reports is enclosed the same way, so that fold would erase gaps tests are being written for. Pin the boundary with two artifacts of one script whose covered regions enclose one zero region by whole span, by line, and by start column. Signed-off-by: quality <quality@hive.kubestellar.io>
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will keep the |
This was referenced Oct 6, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds one regression test to
tests/e2e-coverage-report.test.mjspinning that asingle-line zero-count region is not folded away by a covered region that
encloses it, in the union
collectE2ECoveragebuilds across artifacts.Three separate proposals would fold exactly that shape:
region's span contains it"
startLine:startColumnplus branch ordinalThe test builds two coverage artifacts of one script whose source map gives
line 1 a mid-line mapping. The union they produce is:
The zero region
1:6:1:12is enclosed three different ways — by1:0:3:12from the other artifact (whole-span containment, the #1079 rule), by
1:0:1:12(same line), and by1:6:3:12(same start column, differing end —the #1066 shape). Every line of the file is covered, so the line view sees
nothing and the region has to survive on its own. The test asserts it does.
Why this boundary matters
Measured on the published
e2e-coverageartifact for run37412914368
(artifact
11390121619), re-rendered locally atmain7ab301eandreproducing CI exactly at
src files100.00% lines / 91.29% regions(419/459): every uncovered region in the report is single-line and enclosed
by some covered region from another artifact of the same script. That includes
the arms open work is writing real tests for — GroupLinkStatus's
checkedAtguard (#1094, PR #1113), DirectoryFreshness's plural arms (PR #1104) and
RadarReports' empty-corpus arms (#1097). Enclosure is not evidence of drift,
and a fold keyed on it would erase those gaps rather than fix a report defect.
Related Issue
Refs #1079 (needs-human: the issue asks for a containment fold that the
measured data refutes — the same enclosure holds for genuinely uncovered arms,
and its headline case
MemberProfile.js 10:40:10:48is not span-contained byits covered twin at all, so no containment rule folds it. This PR lands the
guard the issue's own step 2 asks for; deciding what replaces step 1, and
re-deriving
--check-source-regionsin.github/workflows/ci.yml, both need ahuman. Full measurements are in a comment on #1079.)
Coordination
Touches
tests/e2e-coverage-report.test.mjsonly. No open PR touches that file(#1090
scripts/lib/svg-active-content.mjs, #1112package.json, #1104 and#1113 e2e variant fixtures and specs, #1110
tests/e2e-data-fixtures.test.mjsand
tests/tools/e2e-data-fixtures.cjs). It does not changetests/tools/e2e-coverage-report.mjs, so no reported number moves.Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-opus-5 copilot=1.0.88