Repository navigation
test: open a logo-less organization's member profile - #1145
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
MemberProfile mounts only for the organization whose card was clicked, and every existing spec clicks one that has a logo, so useBaseUrl(member.logo || '') at line 10 and the initials-large arm at lines 35-41 are never driven in a browser. The overlay in tests/e2e/fixtures/data/members.json already appends an organization with a null logo, so this is an additive case: the organizations that do have logos keep rendering and both arms are reachable in the same build. Closes #1144 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will keep the |
|
Retracting this PR: it is a duplicate, and the finding it rests on is wrong.
It is not coverage-gated, so it runs in the gating End-to-end tests job as What remains true is only the part this PR already conceded: region My error was selecting work from the open-PR file lists and the uncovered-region Closing; the branch is deleted. Issue #1144 is closed as invalid for the same 🐝 Hive Agent: — hive: agent=quality backend=copilot model=claude-opus-5 copilot=1.0.88 |
Test Improvement
Adds one file:
tests/e2e/member-profile-logo-fallback.spec.js.src/components/MemberDirectory/MemberProfile.jsresolves an organization'slogo before it knows whether there is one, and renders initials when there is
not:
MemberCard.jscarries the identicalmember.logo || ''on its own line 10 andthe browser reaches it, because the directory grid renders every card at once
and some organizations have no logo. The dialog is different: it mounts only for
the one organization whose card was clicked, and every existing spec clicks one
that has a logo —
tests/e2e/interactions.spec.js:154opens BlackRock, andtests/e2e/data-fixtures.spec.js:169reads the fixture organization's cardwithout ever opening it.
Two paired cases: the logo-less organization's profile must render the initials
stage with no
img, and an organization that has a logo must render theimgwith an empty stage otherwise. Pairing them is what makes the assertion evidence
that the ternary switched, rather than that every profile renders the same
stage — the convention
tests/e2e/data-variants.spec.jsstates in its header.This is an additive case, not a build swap: the overlay in
tests/e2e/fixtures/data/members.jsonalready appends one organization with"logo": null, so the hundred-odd organizations that do have logos keeprendering and both arms are reachable in the same build. No variant build and
no new fixture are needed.
What this does not do
The region does not leave the uncovered list, and that was measured rather than
assumed. A report rendered over a run containing only these two cases still
names line 10:
Region dump from the instrumented reporter: key
10:40:10:48is count 0 inevery script carrying the module both before and after, and
35:24:38:15(theinitials arm) is count 0 as well — it stays off the uncovered list only because
the reporter's phantom-region filter drops it. This is the region-attribution
problem tracked in #1066 and #1079. The spec is therefore stated as behaviour,
not as a coverage claim.
Verification
All run locally at
7ab301e+ this diff, on a checkout with Chromium's systemlibraries supplied:
npm run test:unit— 1966 passed, 0 failed.npm run build:e2e:coveragethen the full coverage suite (local-2:node tests/tools/e2e-coverage-run.mjs init,E2E_COVERAGE_DIR/E2E_COVERAGE_RUN_IDexported,npm run test:e2e:coverage) — 324 passed,0 failed, against 321 passed on the unmodified tree (
local-1).npm run report:e2e:coverage -- --check-source 100 --check-source-regions 80 --require-source-filesoverlocal-2— ok;src files | 100.00 | 91.25 | 2099/2099 lines | 417/457 regions, well clear of the gate. The denominatormoves with the scripts a run captures ([quality] e2e region union does not fold single-line '||' fallback arms across the real and variant builds, so correct variant tests lower the gate #1066), so the percentage is 91.25
against 91.41 on the unmodified tree while two more regions are covered.
npx prettier --checkandnpx eslinton the new file — clean.Scope
Only
tests/**, one new file, nothing edited. No production code, no workflowfile. Disjoint from the open hold-gated PRs: #1110 owns
tests/e2e/data-fixtures.spec.js,tests/tools/e2e-data-fixtures.cjsandtests/e2e/fixtures/data/**; #1104 ownstests/e2e/fixtures/data-variants/members.json; #1120 ownstests/e2e/dialog-non-dismissing.spec.jsand claimsMemberProfile.jsline 15,a different arm from line 10; #1142 owns
tests/tools/e2e-coverage-report.mjs.This PR touches none of them.
Related Issue
Closes #1144
Human review required.
— hive: agent=quality backend=copilot model=claude-opus-5 copilot=1.0.88