Repository navigation
ci: ratchet the e2e source-region floor to 95 - #1201
Merged
mrbobbytables merged 1 commit intoOct 8, 2026
Merged
Conversation
The last completion criterion of cncf#1079: re-derive --check-source-regions from the corrected number after cncf#1163 folded the crossing-region source-map drift the issue measured. A full local run of the pipeline (build:e2e:coverage, 340 passing specs, seal, report) at main measures source regions at 95.22% (438/460), up from the 80.98% that set the current floor of 91's predecessor. The three regions cncf#1079 proved executed (MemberProfile.js 10 and 15, MemberCard.js 75) now fold, and MemberDirectory/index.js 31/34/40/43 are covered for real since cncf#1060 merged. Following the established ratchet pattern (measured 91.63 -> floor 91 in cncf#1105), the floor becomes floor(95.22) = 95. Updated in the same change, as tests/e2e-coverage-gate.test.mjs instructs: the workflow gate, the FLOORS guard and its fixtures, the workflow-scripts gating assertion, and the CONTRIBUTING.md recipe. Closes cncf#1079 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the last open criterion of #1079: re-derive the
--check-source-regionsfloor in.github/workflows/ci.ymlfrom the corrected number, now that PR #1163 (merged) folds the crossing-region source-map drift the issue measured. This is the workflow edit the Hive lane could not push.Evidence
Full local run of the e2e coverage pipeline at current main (
29fd4d8):npm run build:e2e:coverage,e2e-coverage-run.mjs init,npm run test:e2e:coverage(340 passed, 0 failed),seal,e2e-coverage-report.mjs --input <dir> --build build:#1079's completion criteria, checked against this run:
MemberProfile.js10 and 15 andMemberCard.js75 are no longer reported uncovered (both files at 100% regions), with no new test written for them — fix(coverage): fold e2e regions whose spans cross across artifacts #1163's crossing fold handles all three pairsMemberDirectory/index.js31/34/40/43 are covered for real — test: cover the member directory's four undriven toolbar controls #1060 mergedtests/e2e-coverage-report.test.mjs)--check-source-regionsre-derived: this PRChanges
Following the established ratchet pattern (measured 91.63 → floor 91 in #1105), the floor becomes floor(95.22) = 95, updated everywhere the value is pinned, in the same change as
tests/e2e-coverage-gate.test.mjsinstructs:.github/workflows/ci.yml:--check-source-regions 91→95tests/e2e-coverage-gate.test.mjs:FLOORS, fixture staleness guards, provenance commenttests/workflow-scripts.test.mjs: the gating-job assertion and its provenance commentCONTRIBUTING.md: the local-reproduction recipeValidation
npm run test:unit:coverage:check: passes (0 failures)node tests/tools/e2e-coverage-report.mjs --input <run> --build build --check-source 100 --check-source-regions 95 --require-source-files: exit 0 against the local runResidue (not blocking)
useFocusTrap.jsline 51 — the fourth same-shape region recorded in #1079's comment — still reports uncovered (file at 90.48% regions, lines 35 and 51) after #1163's fold, so its drift pair is not a strict crossing. It is inside the 95 floor's headroom and separable; noting it on #1079 before close.Closes #1079