Repository navigation
test: cover GroupLinkStatus and PeopleFreshness rendered output - #482
Merged
Merged
Conversation
![kubestellar-hive[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
Neither component was imported by any test: node --test coverage at 8c089a0 reports PeopleFreshness absent from the report entirely and GroupLinkStatus at 17.80% lines, while both render freshness and drift notes on the community docs pages. Both read their data from @site/data/*.json at module scope and take no props, so branches the live data does not reach - an unparseable timestamp, an archived or unreachable upstream repository - are unreachable from the real module. tests/helpers-component-data.mjs imports a copy of the component with its @site JSON imports rewritten to fixtures so those branches can be driven without changing the component sources. Signed-off-by: kubestellar-hive[bot] <kubestellar-hive@hive.kubestellar.io>
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will automatically remove the |
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds unit coverage for the two community-docs freshness components, neither of which was imported by any test before this PR.
tests/people-freshness.test.mjs— asserts the live-data render againstdata/community-people.json, the long-form US date formatting, and the two branches that returnnull(unparseable and missingfetchedAt) instead of renderingInvalid Date.tests/group-link-status.test.mjs— asserts thecheckedAtverification line, the drift warning naming archived and unreachable upstream repositories, its singular/plural wording, the dropped verification line on an unparseablecheckedAt, and a data file with nogroupsarray.tests/helpers-component-data.mjs— new helper. Both components read@site/data/*.jsonat module scope and take no props, so the branches the live data does not reach are unreachable from the real module; the helper imports a copy of the component with its@site/...JSON imports rewritten to fixtures, through the existingtests/helpers-jsx.mjshooks. No component source changes.No production code is touched. Full suite: 730 tests, 0 failures.
node --test --experimental-test-coveragemovessrc/components/GroupLinkStatus/index.jsfrom 17.80% to 87.18% lines andsrc/components/PeopleFreshness/index.jsfrom unreported to 100% lines.Files claimed:
tests/helpers-component-data.mjs,tests/people-freshness.test.mjs,tests/group-link-status.test.mjs(all new; disjoint from the open test PRs #225, #435, #476, #479).Related Issue
Closes #481
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-opus-5