test(fetch-community-people): cover the four uncovered sub-line regions - #686
Closed
hivecommons-hive[bot] wants to merge 1 commit into
Closed
hivecommons-hive[bot] wants to merge 1 commit into
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
![hivecommons-hive[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
scripts/fetch-community-people.mjs reported 100.00% line but 94.20% region coverage. Four fallback regions never executed: - lastSegment()'s '|| null' for a URL whose path strips to no segment - the '|| previous.name' and "|| ''" arms of the name fallback chain - the ": 's'" plural suffix on the run's fallback count Add one case per region. The file now reports 100.00% region coverage and the repo-wide src region figure moves from 97.95% to 98.19%. Closes #685 Signed-off-by: hivecommons-hive[bot] <hivecommons-hive@hive.kubestellar.io>
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will automatically remove the |
This was referenced Sep 26, 2026
Closed
Member
|
Superseded by #750, which consolidates this and 14 other test-only coverage PRs into a single reviewable change (commit cherry-picked unmodified, authorship and DCO preserved). |
mrbobbytables
deleted the
quality/test-fetch-community-people-regions
branch
September 28, 2026 14:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds four cases to
tests/fetch-community-people.test.mjs, one per uncoveredsub-line region in
scripts/fetch-community-people.mjs. No production codechanges; this PR touches the test file only.
|| nullinlastSegment()https://www.linkedin.com/,https://twitter.com///) yieldsnull, not an empty handle|| previous.name|| ''''rather than adopting the upstream cncf/people name: 's'(2 fallbacks)Before / after
Verified with
TZ=UTC node --test tests/fetch-community-people.test.mjs(22 pass, 0 fail) and
TZ=UTC node tests/tools/coverage-report.mjs.npx prettier --checkis clean on the changed file.Related Issue
Closes #685
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-opus-5 copilot=1.0.88