Skip to content

Enable zh-cn path link checks - #3656

Open
Shaohan-He wants to merge 2 commits into
cncf:mainfrom
Shaohan-He:codex/zh-cn-enable-link-checks
Open

Shaohan-He wants to merge 2 commits into
cncf:mainfrom
Shaohan-He:codex/zh-cn-enable-link-checks

Conversation

@Shaohan-He

Copy link
Copy Markdown

Related issue number or link

Part of #3190

Description

Fixes remaining invalid zh-cn internal paths, then updates .htmltest.yml\ so zh-cn is no longer excluded from path link checking. zh-tw remains ignored because it is tracked separately in #3190.

Validation

  • \git diff --check\
  • Custom zh-cn internal path check script: passed

  • pm install --no-package-lock\ timed out locally before dependencies were installed, so the full
    pm run check:links\ validation is left to CI.

Checklist before opening this PR

  • I have signed off my commits.
  • I have checked the changed zh-cn internal links.

Signed-off-by: Shaohan He <290298661@qq.com>
@netlify

netlify Bot commented Jun 22, 2026

Copy link
Copy Markdown

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 1d30a59
🔍 Latest deploy log https://app.netlify.com/projects/cncfglossary/deploys/6a3dd84b1144730008174500
😎 Deploy Preview https://deploy-preview-3656--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@seokho-son

seokho-son commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Thanks @Shaohan-He :)

Your PR contents lgtm. (actually, update for localization content needs to be handled by dev-xx branch not main branch directly, but I guess the zh-ch team may handle this PR in the main branch since this update is a bug fix)

The link checker identified additional broken links. Could you fix the following links?

========================================================================
zh-cn/scalability/index.html
  target does not exist --- zh-cn/scalability/index.html --> /zh/cluster/
zh-cn/container-orchestration/index.html
  target is a directory, href lacks trailing slash --- zh-cn/container-orchestration/index.html --> /zh-cn/kubernetes
  target is a directory, href lacks trailing slash --- zh-cn/container-orchestration/index.html --> /zh-cn/microservices
  target is a directory, href lacks trailing slash --- zh-cn/container-orchestration/index.html --> /zh-cn/distributed-systems
========================================================================

Signed-off-by: Shaohan He <290298661@qq.com>
@Shaohan-He

Copy link
Copy Markdown
Author

Thanks @seokho-son !

I fixed the remaining zh-cn link checker failures in commit 1d30a59:

  • Updated /zh/cluster/ to /zh-cn/cluster/
  • Added trailing slashes for /zh-cn/kubernetes/, /zh-cn/microservices/, and /zh-cn/distributed-systems/

git diff --check passed locally.

I also tried running the link check locally, but it failed because Hugo is not installed in my local environment, so I’ll rely on CI for the final validation.

It looks like the workflows are currently awaiting maintainer approval. Could you please approve and rerun them when convenient?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang/zh for Chinese

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants