Skip to content

Open-issue dedup and consolidation plan: #207 partial duplicate, test.yml group, coverage-gap groups #215

Description

@mrbobbytables

Summary

A review of the 26 currently open issues found one partial functional duplicate (#207) and three natural consolidation groups. Most open issues are 1:1 mirrors of the open automated test-coverage PRs (see #214 for the PR-side consolidation plan), so the issue-side grouping should track the same structure and merge order.

Findings

1. Partial duplicate: #207 — Priority: high (close/trim first)

#207 re-reports branches already claimed by other open issues, despite stating it is disjoint from #173–#206:

Only src/run.ts:40 (non-Error rejection → setFailed(String(error))) is unique to #207.

Action: close #207 as a duplicate of #197 + #176, or trim it down to just the run.ts:40 gap.

2. Consolidate: test.yml workflow issues — #171, #209, #213 — Priority: high

All three propose changes to the same file, .github/workflows/test.yml:

Landing these as three separate PRs guarantees edit conflicts in one workflow file. Action: consolidate into a single "CI workflow improvements" issue/PR.

3. Consolidate: coverage-gap issues (17 issues mirroring the open PRs) — Priority: medium

Each of these is the tracking issue for exactly one open coverage PR. Group them the same way as the PR consolidation in #214, and close each group when its consolidated PR merges:

Group Issues Mirrors PRs
issueComment handlers #174, #182, #184, #195, #205 #175, #183, #185, #196, #206
Plugins (tide/approve/misc) #186, #191, #203 #187, #192, #204
Labels #176 #177
Utils (sleep/mergeQueue/auth/utils) #180, #189, #193, #197 #181, #190, #194, #198
Cron jobs + PR events #172, #178, #199 #173, #179, #200
Entry point #211 #212
Coverage threshold gate #201 #202

4. Leave standalone — Priority: low / n/a

Recommended merge / resolution order

  1. Close or trim [quality] uncovered error branches in run.ts, utils/config.ts fetch paths, utils/comments.ts createCommentOnce and labels/prefixed.ts #207 — removes the duplicate before any consolidation work starts.
  2. Merge dependabot PR chore(deps-dev): bump the dev-dependencies group across 1 directory with 5 updates #188 — independent; unblocked further by the [quality] dependabot PRs bumping ncc-bundled deps always fail the dist/ gate — add a repack-dist job to test.yml #171 repack-dist job if it lands first.
  3. CI workflow group ([quality] dependabot PRs bumping ncc-bundled deps always fail the dist/ gate — add a repack-dist job to test.yml #171, [quality] test.yml runs vitest coverage but never publishes the report — add lcov/json-summary artifact and job summary #209, [quality] test.yml runs build-test twice per commit on every PR branch — narrow push to main and add a concurrency group #213) — one combined PR; early merge means every subsequent PR benefits from deduped runs and published coverage.
  4. Coverage-gap groups — in any order (they touch disjoint test files): issueComment → plugins → labels → utils → cron/PR events → entry point.
  5. [quality] vitest coverage thresholds sit ~11 points below actual coverage; the gate cannot catch regressions #201 / PR chore(coverage): raise vitest coverage thresholds to the current floor #202 last — the raised vitest thresholds only reflect reality once all coverage PRs have merged; landing it earlier would fail CI on the remaining ones.
  6. [CI / CD] System to perform tasks on a test repo, end to end #40 — independent, longer-term; schedule separately.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions