Repository navigation
[quality] normalizeSweep in src/utils/config.ts: empty sweep mapping and non-Error lookback rethrow branches are untested #228
Description
Finding
src/utils/config.ts normalizeSweep has two branch arms with no unit coverage:
- line 594,
if (raw.lookback !== undefined)false arm — asweep: {}mapping with nolookback. Every existing parse test in__tests__/cronJobTest/sweep.test.tssupplies alookback(valid or invalid), so the pass-through tostripUndefined({ lookback: undefined })is never exercised. - line 603,
e instanceof Error ? e.message : enon-Error arm —parseDurationonly ever throwsError, so the fallback is reachable only by faking the thrown value.
Unit evidence: npm ci && npx vitest run --coverage on main @ c48bd6d → config.ts | 100 stmts | 99.03 branch | 100 funcs | 100 lines | uncovered 594,603.
End-to-end evidence: the prow / prow check dogfoods the built action but emits no coverage data (see #209), so there is no e2e coverage source to compare against; this finding is unit-only. Priority is therefore capped at medium.
Disjoint from the open hold-gated PRs: #217 (auth), #219 (tide queue), #221 (approve events), #223 (labelSync/approve/lgtm/mergeQueue), #225 (meow/trigger/tide), #227 (requireMatchingLabel) — none touch config.ts or a config test file.
Recommendation
Add __tests__/utils/configSweep.test.ts with two cases:
-
parseProwConfig('x', 'sweep: {}\n')→{ sweep: {} } -
vi.mock('../../src/utils/duration', { spy: true }), makeparseDurationthrow a string once, assertparseProwConfigrethrowsx: <string>
Brings config.ts to 100% branch coverage.
Priority
- Impact: low
- Effort: low
Filed by quality agent (hold-gated mode)
🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: c48bd6d
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88
Activity
github-actions commentedon Sep 29, 2026
Please add a kind label with
/kind failing-testor/kind cleanup.hivecommons-hive commentedon Oct 3, 2026
task-list sweep: 0 of 2 items ticked. Not closing yet — outstanding boxes remain.
Outstanding items:
parseProwConfig('x', 'sweep: {}\n')→{ sweep: {} }vi.mock('../../src/utils/duration', { spy: true }), makeparseDurationthrow a string once, assertparseProwConfigrethrowsx: <string>Merged PRs referencing this issue so far:
This comment is edited in place by the task-list sweep on every cycle; it is not duplicated.
hivecommons-hive commentedon Oct 3, 2026
Verified resolved on
main@ 61577d5: #229 merged__tests__/utils/configSweep.test.ts;npx vitest run --coverage→config.ts | 100 | 100 | 100 | 100.🐝 Hive Agent:
quality| Instance:hosted-available-lke648397-260827-5q9t| SHA:61577d5— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88