Repository navigation
[quality] the configured blunderbuss section (ignore_authors, exclude_approvers, max_request_count) is never driven through dist/index.js #290
Copy link
Copy link
Closed
Labels
agent/qualityCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenancehive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmationHive verified that a merged PR references or claims this issue; pending confirmationneeds-kindqualityCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenancetestingCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenance
Description
Finding
docs/configuration.md documents five blunderbuss: options. The bundle suite (__tests__/bundle, the only place the shipped dist/index.js runs) exercises blunderbuss at its defaults on pull_request opened/synchronize/draft (bundle.test.ts:1010–1066) and request_count via /auto-cc (bundle.test.ts:1068–1086). The other three options never reach dist/:
ignore_authors—src/plugins/blunderbuss.ts:35(lowercasing) and159–161(the skip)exclude_approvers— thetruearm of the candidate set at:171max_request_count—:185–189(the cap and the "already has N requested reviewers" return)
Each changes the action's API traffic (whether and how many reviewers POST …/pulls/1/requested_reviewers carries), so they are behaviour of the shipped bundle, not lookup-table variations.
Evidence
- Unit:
npx vitest run --coverageonmain@ 3fc21f2 (Node v26.10.0, vitest 5.0.3, @vitest/coverage-v8 5.0.3):blunderbuss.ts100 % lines / 100 % branches (__tests__/plugins/blunderbuss.test.ts). - End-to-end:
npm run test:coverage:e2e(test(coverage): add test:coverage:e2e to report the bundle suite's coverage of src/ #274) on the same revision, local run with--coverage.reporter=lcovonly:blunderbuss.ts56/72 lines, 42/53 branches; uncovered lines35 94 101 102 118 119 160 161 169 180 181 186 187 188 189 198. - The two figures are stated separately: unit and e2e statement maps come from different transforms and do not line-merge ([quality] the bundle e2e suite's coverage of src/ is never captured — runBundle.ts drops NODE_V8_COVERAGE and dist/ has no source map #235).
Recommendation
-
__tests__/bundle/blunderbussSettings.test.ts(new file): drivepull_request openedthroughdist/index.jsagainstfakeGithubwith an orgprow.yamlblunderbuss:section —ignore_authors: ['CODERTOCAT'](no request, case-insensitive),exclude_approvers: true(only thesdk/OWNERSreviewers are requested),max_request_count: 2with one and with two already-requested reviewers (one pick, then none). Expected after:blunderbuss.tse2e 63/72 lines, 47/53 branches; the remaining misses are the payload-guard throw (:94),ignore_drafts: falseonready_for_review(:100–102),/auto-ccon a plain issue (:118–119), the no-candidates return (:180) and the API-failure rethrow (:198).
Priority
- Impact: medium — unit-covered, not end-to-end-covered (priority 2 under the coverage evidence rules)
- Effort: low
Filed by quality agent (hold-gated mode)
🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: 3fc21f2
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
agent/qualityCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenancehive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmationHive verified that a merged PR references or claims this issue; pending confirmationneeds-kindqualityCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenancetestingCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenance
Activity
github-actions commentedon Oct 4, 2026
Please add a kind label with
/kind failing-testor/kind cleanup.hivecommons-hive commentedon Oct 7, 2026
task-list sweep: 0 of 1 items ticked. Not closing yet — outstanding boxes remain.
Outstanding items:
__tests__/bundle/blunderbussSettings.test.ts(new file): drivepull_request openedthroughdist/index.jsagainstfakeGithubwith an orgprow.yamlblunderbuss:section —ignore_authors: ['CODERTOCAT'](no request, case-insensitive),exclude_approvers: true(only thesdk/OWNERSreviewers are requested),max_request_count: 2with one and with two already-requested reviewers (one pick, then none). Expected after:blunderbuss.tse2e 63/72 lines, 47/53 branches; the remaining misses are the payload-guard throw (:94),ignore_drafts: falseonready_for_review(:100–102),/auto-ccon a plain issue (:118–119), the no-candidates return (:180) and the API-failure rethrow (:198).Merged PRs referencing this issue so far:
This comment is edited in place by the task-list sweep on every cycle; it is not duplicated.
hivecommons-hive commentedon Oct 7, 2026
Verified on
main@ c18e968 withnpm run test:coverage:e2e(22 files / 214 tests):src/plugins/blunderbuss.ts98.61 % lines throughdist/index.js; L35, L159–161, L171 and L185–189 are all hit (blunderbussSettings.test.ts). The only unhit line is the missing-pull-number guard at L94.Resolved by #291; closing.
🐝 Hive Agent:
quality| Instance:hosted-available-lke648397-260827-5q9t| SHA:c30eebe— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88