Skip to content

[quality] the configured blunderbuss section (ignore_authors, exclude_approvers, max_request_count) is never driven through dist/index.js #290

Closed

Description

@hivecommons-hive

Finding

docs/configuration.md documents five blunderbuss: options. The bundle suite (__tests__/bundle, the only place the shipped dist/index.js runs) exercises blunderbuss at its defaults on pull_request opened/synchronize/draft (bundle.test.ts:1010–1066) and request_count via /auto-cc (bundle.test.ts:1068–1086). The other three options never reach dist/:

  • ignore_authors — src/plugins/blunderbuss.ts:35 (lowercasing) and 159–161 (the skip)
  • exclude_approvers — the true arm of the candidate set at :171
  • max_request_count — :185–189 (the cap and the "already has N requested reviewers" return)

Each changes the action's API traffic (whether and how many reviewers POST …/pulls/1/requested_reviewers carries), so they are behaviour of the shipped bundle, not lookup-table variations.

Evidence

Recommendation

  • __tests__/bundle/blunderbussSettings.test.ts (new file): drive pull_request opened through dist/index.js against fakeGithub with an org prow.yaml blunderbuss: section — ignore_authors: ['CODERTOCAT'] (no request, case-insensitive), exclude_approvers: true (only the sdk/OWNERS reviewers are requested), max_request_count: 2 with one and with two already-requested reviewers (one pick, then none). Expected after: blunderbuss.ts e2e 63/72 lines, 47/53 branches; the remaining misses are the payload-guard throw (:94), ignore_drafts: false on ready_for_review (:100–102), /auto-cc on a plain issue (:118–119), the no-candidates return (:180) and the API-failure rethrow (:198).

Priority

  • Impact: medium — unit-covered, not end-to-end-covered (priority 2 under the coverage evidence rules)
  • Effort: low

Filed by quality agent (hold-gated mode)


🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: 3fc21f2

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

Activity

  1. github-actions commented on Oct 4, 2026

    @github-actions
    Contributor

    Please add a kind label with /kind failing-test or /kind cleanup.

  2. added
    🐝 covered by PRHive verified that an open PR references or claims this issue; still actionable until confirmed
    hive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmation
    and removed
    🐝 covered by PRHive verified that an open PR references or claims this issue; still actionable until confirmed
    on Oct 4, 2026
  3. hivecommons-hive commented on Oct 7, 2026

    @hivecommons-hive
    ContributorAuthor

    task-list sweep: 0 of 1 items ticked. Not closing yet — outstanding boxes remain.

    Outstanding items:

    • 🔲 __tests__/bundle/blunderbussSettings.test.ts (new file): drive pull_request opened through dist/index.js against fakeGithub with an org prow.yaml blunderbuss: section — ignore_authors: ['CODERTOCAT'] (no request, case-insensitive), exclude_approvers: true (only the sdk/OWNERS reviewers are requested), max_request_count: 2 with one and with two already-requested reviewers (one pick, then none). Expected after: blunderbuss.ts e2e 63/72 lines, 47/53 branches; the remaining misses are the payload-guard throw (:94), ignore_drafts: false on ready_for_review (:100–102), /auto-cc on a plain issue (:118–119), the no-candidates return (:180) and the API-failure rethrow (:198).

    Merged PRs referencing this issue so far:

    This comment is edited in place by the task-list sweep on every cycle; it is not duplicated.

  4. hivecommons-hive commented on Oct 7, 2026

    @hivecommons-hive
    ContributorAuthor

    Verified on main @ c18e968 with npm run test:coverage:e2e (22 files / 214 tests): src/plugins/blunderbuss.ts 98.61 % lines through dist/index.js; L35, L159–161, L171 and L185–189 are all hit (blunderbussSettings.test.ts). The only unhit line is the missing-pull-number guard at L94.

    Resolved by #291; closing.


    🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: c30eebe

    — hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/qualityCreated by Hive for agent-filed issue provenancehive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmationneeds-kindqualityCreated by Hive for agent-filed issue provenancetestingCreated by Hive for agent-filed issue provenance

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions