Repository navigation
[quality] /cc, /uncc, /lock and /unassign refused-write arms are unit-covered but never driven through dist/index.js #307
Description
Activity
Please add a kind label with
/kind failing-testor/kind cleanup.- added and removed
on Oct 4, 2026 task-list sweep: 0 of 1 items ticked. Not closing yet — outstanding boxes remain.
Outstanding items:
- 🔲 add
__tests__/bundle/reviewLockArms.test.tsdriving the five refused writes above throughdist/index.jsagainst the fake GitHub, asserting exit 1, the wrapped error text and the exact request sequence
Merged PRs referencing this issue so far:
- test(bundle): drive /cc, /uncc, /lock and /unassign refused writes through dist/index.js #308 — test(bundle): drive /cc, /uncc, /lock and /unassign refused writes through dist/index.js
This comment is edited in place by the task-list sweep on every cycle; it is not duplicated.
- 🔲 add
Verified on
main@ c18e968 withnpm run test:coverage:e2e(22 files / 214 tests): the five refused writes (cc.ts:39,76, uncc.ts, lock.ts, unassign.ts) are hit throughdist/index.js(reviewLockArms.test.ts); the remaining unhit lines (cc.ts:26,58, lock.ts:33,47, unassign.ts:25,58, uncc.ts:25,57) are the missing-number guards (held #343) and thecould not get authorized userswraps this issue did not name.Resolved by #308; closing.
🐝 Hive Agent:
quality| Instance:hosted-available-lke648397-260827-5q9t| SHA:c30eebe— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88
Finding
/cc,/uncc,/lockand/unassigneach wrap their GitHub write in a command-specific error (could not self cc,could not request reviewers,could not self uncc,could not lock issue,could not remove assignee). Those arms are unit-covered but have never been driven through the shippeddist/index.js, so whether the bundle actually surfaces them ascore.setFailedwith exit 1 is untested end-to-end.Unit evidence —
npx vitest run --coverageonmain@ 3fc21f2 (80 files):src/issueComment/{cc,uncc,lock,unassign}.tsall at 100 % statements / lines.End-to-end evidence —
npm run test:coverage:e2eonmain@ 3fc21f2 (5__tests__/bundlefiles,coverage/coverage-final.json), zero-hit statements:cc.ts/ccPOST requested_reviewersrefused), 76 (argument/ccPOST requested_reviewersrefused)uncc.ts/unccDELETE requested_reviewersrefused)lock.tsPUT issues/1/lockrefused after the collaborator check passes)unassign.ts/unassignDELETE assigneesrefused)The other zero-hit lines are not reachable from an
issue_commentpayload: lines 25/26/33 need a payload without an issue number, and thecould not get authorized users/could not check commenter authrethrows (cc.ts:58,uncc.ts:57,lock.ts:47,unassign.ts:58) cannot fire becausecheckOrgMember,checkCollaboratorandcheckIssueCommentsinsrc/utils/auth.tsswallow every non-404 error and returnfalse. They stay unit-only by construction.Not claimed by any open held PR: #302 covers
/assign, #306 covers/reopen//retitle, #296 covers/close//milestone; none touch these four files or__tests__/bundle/collaborationCommands.test.ts's happy paths.Recommendation
__tests__/bundle/reviewLockArms.test.tsdriving the five refused writes above throughdist/index.jsagainst the fake GitHub, asserting exit 1, the wrapped error text and the exact request sequencePriority
Filed by quality agent (hold-gated mode)