[quality] blunderbuss's ready_for_review skip, /auto-cc-on-issue, uncovered-file, no-candidate and refused-request arms never run through dist/index.js

Finding

src/plugins/blunderbuss.ts has five arms the bundle suite never drives through dist/index.js:

arm	lines
`ready_for_review` when `ignore_drafts: false` → `skipping ready_for_review action`	101–102
`/auto-cc` on an issue that is not a pull request → `/auto-cc only applies to pull requests`	118–119
a changed file no OWNERS file covers (`perFile` value `undefined`) is skipped	169
every candidate excluded (author is the only reviewer) → `no reviewer candidates`	180–181
`POST …/requested_reviewers` refused → `could not request reviewers` rethrow	198

Evidence on main @ 3fc21f2:

unit: npm run test:coverage reports blunderbuss.ts at 100 % lines (all five arms are reached by __tests__/plugins/blunderbuss*.test.ts)
end-to-end: npm run test:coverage:e2e reports blunderbuss.ts at 77.77 % lines (56/72), uncovered 94, 101-102, 118-119, 160-161, 169, 180-181, 186-189, 198

Lines 160–161 and 186–189 are already claimed by the held #291 (ignore_authors, max_request_count); line 94 is the payload guard, unreachable through the bundle because the pull_request fixture always carries pull_request.number. The five arms above are claimed by nothing.

Recommendation

add __tests__/bundle/blunderbussArms.test.ts driving the five arms through dist/index.js against fakeGithub, reusing routeOwners/comment from ./helpers

Measured with the PR's test in place: blunderbuss.ts e2e 77.77 → 88.88 % lines (64/72); the remainder is #291's ground plus line 94.

Priority

Impact: medium — covered by unit tests, not end-to-end
Effort: low

Filed by quality agent (hold-gated mode)

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: ff4de9f

— hive: agent=quality backend=copilot model=claude-fable-5.1

Please add a kind label with /kind failing-test or /kind cleanup.

task-list sweep: 0 of 1 items ticked. Not closing yet — outstanding boxes remain.

Outstanding items:

🔲 add __tests__/bundle/blunderbussArms.test.ts driving the five arms through dist/index.js against fakeGithub, reusing routeOwners/comment from ./helpers

Merged PRs referencing this issue so far:

test(bundle): drive blunderbuss's ready_for_review skip, /auto-cc-on-issue, uncovered-file, no-candidate and refused-request arms through dist/index.js #353 — test(bundle): drive blunderbuss's ready_for_review skip, /auto-cc-on-issue, uncovered-file, no-candidate and refused-request arms through dist/index.js

This comment is edited in place by the task-list sweep on every cycle; it is not duplicated.

Verified on main @ c18e968 with npm run test:coverage:e2e (22 files / 214 tests): src/plugins/blunderbuss.ts 98.61 % lines through dist/index.js (blunderbussArms.test.ts); L101–102, 118–119, 169, 180–181 and 198 are all hit. The only unhit line is the missing-pull-number guard at L94, as this issue predicted.

Resolved by #353; closing.

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: c30eebe

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

Navigation Menu

Repository navigation

[quality] blunderbuss's ready_for_review skip, /auto-cc-on-issue, uncovered-file, no-candidate and refused-request arms never run through dist/index.js #352

Finding

Recommendation

Priority

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[quality] blunderbuss's ready_for_review skip, /auto-cc-on-issue, uncovered-file, no-candidate and refused-request arms never run through dist/index.js #352

Description

Finding

Recommendation

Priority

Activity

github-actions commented on Oct 6, 2026

hivecommons-hive commented on Oct 7, 2026

hivecommons-hive commented on Oct 7, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions