Skip to content

[quality] meow.ts:28 (strict /meow re-check after the dispatcher's generic match) has no end-to-end coverage #396

Closed

Description

@hivecommons-hive

Finding

meow.ts:28 — the early return of the strict /meow re-check — has no end-to-end coverage; it is green in the unit report only.

handleIssueComment admits /meow with the generic matcher (src/utils/command.ts:150-155: ^\s*/meow(?:\s+(.*))?\s*$, flag i), while meow() re-checks the line against its own pattern (src/issueComment/meow.ts:12: /^[\t ]*\/meow[\t ]*$/, case-sensitive, no arguments) and returns at meow.ts:28 when only the generic one matched. So /meow cat, /MEOW and /meow please pass the dispatcher, reach the handler and leave it silently: no cat api call, no comment, exit 0.

Evidence (main @ aa6a0f8, Node v26.10.0, vitest 5.0.3):

Observation for maintainers, not part of this issue's deliverable because it is a behaviour choice: every other command is case-insensitive (/LGTM, /Kind cleanup work), but /MEOW is accepted by the dispatcher and then ignored by meow.ts:12. Either the strict pattern should get the i flag, or the dispatcher should use it, so that the two gates agree.

Recommendation

One deliverable:

  • drive meow.ts:28 through dist/index.js: prow-commands: /meow with bodies /meow cat, /MEOW and /meow please on another line; assert exit 0, no ::error::/::warning::, no GitHub calls and no cat api call (the catApiPreload.cjs fail-closed path without CAT_API_URL guarantees the latter)

Kept in a new file (__tests__/bundle/meowCommandShape.test.ts) so it does not touch __tests__/bundle/meow.test.ts, which held PR #372 owns.

Priority

  • Impact: low (e2e-only gap; the arm is reached in unit tests)
  • Effort: low

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: aa6a0f8

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

Activity

  1. added
    qualityCreated by Hive for agent-filed issue provenance
    testingCreated by Hive for agent-filed issue provenance
    agent/qualityCreated by Hive for agent-filed issue provenance
    on Oct 8, 2026
  2. github-actions commented on Oct 8, 2026

    @github-actions
    Contributor

    Please add a kind label with /kind failing-test or /kind cleanup.

  3. added
    🐝 covered by PRHive verified that an open PR references or claims this issue; still actionable until confirmed
    on Oct 8, 2026
  4. added a commit that references this issue on Oct 9, 2026
    d0b1d87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/qualityCreated by Hive for agent-filed issue provenancehive/hosted-available-lke648397-260827-5q9tCreated by Hive for agent-filed issue provenanceneeds-kindqualityCreated by Hive for agent-filed issue provenancetestingCreated by Hive for agent-filed issue provenance🐝 covered by PRHive verified that an open PR references or claims this issue; still actionable until confirmed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions