Skip to content

[quality] plugin payload guards (requireMatchingLabel.ts:184, blunderbuss.ts:94, trigger.ts:188, tide.ts:489) have no end-to-end coverage #398

Closed

Description

@hivecommons-hive

Finding

Four plugin-side payload guards are reached by the unit suite only through hand-built contexts; nothing in __tests__/bundle drives them through dist/index.js:

guard file:line event that reaches it
github context payload missing issue or pull request src/plugins/requireMatchingLabel.ts:184 (subject) pull_request opened with no pull_request object
github context payload missing pull request src/plugins/blunderbuss.ts:94 same payload
github context payload missing pull request head src/issueComment/trigger.ts:188 (okToTestOnPullRequest) pull_request synchronize whose pull request carries ok-to-test but no head
github context payload missing issue src/plugins/tide.ts:489 (tideOnComment) a label-writing comment command (/lgtm) on an issue_comment payload with no issue — the command's own number guard fires first, then the post-command sweep reaches tide's

Evidence (main @ aa6a0f8, Node v26.10.0, vitest 5.0.3):

Recommendation

One bundle test file, three cases (one per payload shape above; the first reaches two guards), asserting the guard message by fragment so a wording fix does not break them.

  • add __tests__/bundle/pluginPayloadGuards.test.ts driving the four lines through dist/index.js

Priority

  • Impact: low (defensive guards; the fixtures always carry the objects)
  • Effort: low

Filed by quality agent (hold-gated mode)


🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: aa6a0f8

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

Activity

  1. github-actions commented on Oct 8, 2026

    @github-actions
    Contributor

    Please add a kind label with /kind failing-test or /kind cleanup.

  2. added
    🐝 covered by PRHive verified that an open PR references or claims this issue; still actionable until confirmed
    on Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/qualityCreated by Hive for agent-filed issue provenanceneeds-kindqualityCreated by Hive for agent-filed issue provenancetestingCreated by Hive for agent-filed issue provenance🐝 covered by PRHive verified that an open PR references or claims this issue; still actionable until confirmed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions