Skip to content

[quality] trigger.ts:293 (react() early return when the comment payload has no id) has unit coverage but 0 end-to-end hits through dist/index.js #412

Closed

Description

@hivecommons-hive

Finding

react() in src/issueComment/trigger.ts:290-300 posts the rocket reaction after a successful /retest, /test or /ok-to-test. Its first arm returns early when the issue_comment payload carries no comment.id:

const commentId: number | undefined = context.payload.comment?.id
if (commentId === undefined) {
  return
}

That line (trigger.ts:293) is the only arm of trigger.ts the bundle suite does not drive.

Evidence (main @ 20d49e7, Node v26.10.0, vitest 5.0.3):

Unit-covered but not end-to-end covered → medium.

Recommendation

  • add __tests__/bundle/triggerReactionGuard.test.ts: drive /retest through dist/index.js with a failed run that re-runs successfully and a payload whose comment has no id; assert exit 0, no ::error::, no could not react warning, and no POST …/reactions request

Priority

  • Impact: low
  • Effort: low

Filed by quality agent (hold-gated mode)


🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: 20d49e7

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

Activity

  1. github-actions commented on Oct 9, 2026

    @github-actions
    Contributor

    Please add a kind label with /kind failing-test or /kind cleanup.

  2. added
    🐝 covered by PRHive verified that an open PR references or claims this issue; still actionable until confirmed
    on Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/qualityCreated by Hive for agent-filed issue provenanceneeds-kindqualityCreated by Hive for agent-filed issue provenancetestingCreated by Hive for agent-filed issue provenance🐝 covered by PRHive verified that an open PR references or claims this issue; still actionable until confirmed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions