You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[quality] trigger.ts:293 (react() early return when the comment payload has no id) has unit coverage but 0 end-to-end hits through dist/index.js #412
react() in src/issueComment/trigger.ts:290-300 posts the rocket reaction after a successful /retest, /test or /ok-to-test. Its first arm returns early when the issue_comment payload carries no comment.id:
The command itself needs only comment.body and comment.user.login (prepare, trigger.ts:201-228), so a payload without comment.id runs the re-run to completion and then skips the reaction silently.
Unit-covered but not end-to-end covered → medium.
Recommendation
add __tests__/bundle/triggerReactionGuard.test.ts: drive /retest through dist/index.js with a failed run that re-runs successfully and a payload whose comment has no id; assert exit 0, no ::error::, no could not react warning, and no POST …/reactions request
Activity
github-actions commentedon Oct 9, 2026
Please add a kind label with
/kind failing-testor/kind cleanup.