Skip to content

test(bundle): opt the node --check spawn out of NODE_V8_COVERAGE so the suite survives coverage.autoAttachSubprocess #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 1 commit into from
Oct 2, 2026
+4 −1
Merged

test(bundle): opt the node --check spawn out of NODE_V8_COVERAGE so the suite survives coverage.autoAttachSubprocess #236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion __tests__/bundle/bundle.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,10 @@ describe('dist/index.js', () => {
it('is a syntactically valid bundle with no unresolved modules', () => {
expect(fs.existsSync(bundlePath)).toBe(true)

const check = spawnSync(process.execPath, ['--check', bundlePath], { encoding: 'utf8' })
// node re-injects the parent's NODE_V8_COVERAGE into any child env lacking the key, and
// `node --check` crashes under it (nodejs v26 source-map cache); an empty value opts out
const env = { ...process.env, NODE_V8_COVERAGE: '' }
const check = spawnSync(process.execPath, ['--check', bundlePath], { encoding: 'utf8', env })
expect(check.status, check.stderr).toBe(0)

expect(fs.readFileSync(bundlePath, 'utf8')).not.toContain('webpackMissingModule')
Expand Down
Loading