Skip to content

test: assert docs/commands.md rows match the handleIssueComment dispatcher and the prow.yml prow-commands default - #254

Merged
github-actions[bot] merged 1 commit into
mainfrom
quality/test-commands-doc-drift
Oct 2, 2026
Merged

github-actions[bot] merged 1 commit into
mainfrom
quality/test-commands-doc-drift

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Test Improvement

Adds __tests__/commands.test.ts (new file; touches nothing else) covering the doc/dispatcher invariant described in #253:

  • every command the dispatcher implements — the handlers keys and commandAliases in src/issueComment/handleIssueComment.ts, plus prefixedLabelCommands/fixedLabelCommands and their removeCommandFor forms — has a table row in docs/commands.md;
  • every /command row in docs/commands.md is implemented (the /<key> placeholders are skipped);
  • /override, /skip, /retest-required remain listed as unsupported with neither a row nor a handler;
  • the prow-commands default of .github/workflows/prow.yml equals exactly handlers-minus-/meow plus the label commands, making the "every built-in command except /meow" description an asserted equality.

Mutation-checked: renaming one doc row fails both inclusion tests. npx vitest run __tests__/commands.test.ts and npx eslint __tests__/commands.test.ts pass on main @ c48bd6d.

Cluster: docs/commands.md ↔ handleIssueComment.ts / labels/{fixed,prefixed}.ts / prow.yml input default. Disjoint from #232 (__tests__/workflows.test.ts, action.yml inputs) and #234 (__tests__/runtime.test.ts).

Related Issue

Closes #253


Filed by quality agent (hold-gated mode). Human review required.

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

…tcher and the prow.yml prow-commands default

Adds __tests__/commands.test.ts: every handler, alias and label command
(with its /remove- form) has a row in docs/commands.md and vice versa;
/override, /skip and /retest-required stay listed as unsupported with
neither a row nor a handler; the reusable workflow's prow-commands
default equals exactly the handlers minus /meow plus the label commands.

Closes #253

Signed-off-by: quality <quality@hive.kubestellar.io>
@hivecommons-hive
hivecommons-hive Bot requested a review from jpmcb as a code owner October 1, 2026 03:20
@hivecommons-hive hivecommons-hive Bot added the hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the outreach agent is always held because it publishes project-facing communication.

Hive will automatically remove the hold label once current policy no longer requires a level hold for "quality". If this is an outreach PR, a human must review it and remove the label.

@jeefy

jeefy commented Oct 2, 2026

Copy link
Copy Markdown
Member

/kind cleanup
/lgtm
/approve
/hold cancel

@github-actions github-actions Bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 2, 2026
@github-actions
github-actions Bot merged commit c824ac4 into main Oct 2, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[quality] docs/commands.md has no test tying its command rows to the dispatcher in handleIssueComment.ts

1 participant