test: assert docs/commands.md rows match the handleIssueComment dispatcher and the prow.yml prow-commands default - #254
Merged
Conversation
…tcher and the prow.yml prow-commands default Adds __tests__/commands.test.ts: every handler, alias and label command (with its /remove- form) has a row in docs/commands.md and vice versa; /override, /skip and /retest-required stay listed as unsupported with neither a row nor a handler; the reusable workflow's prow-commands default equals exactly the handlers minus /meow plus the label commands. Closes #253 Signed-off-by: quality <quality@hive.kubestellar.io>
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will automatically remove the |
This was referenced Oct 1, 2026
Member
|
/kind cleanup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds
__tests__/commands.test.ts(new file; touches nothing else) covering the doc/dispatcher invariant described in #253:handlerskeys andcommandAliasesinsrc/issueComment/handleIssueComment.ts, plusprefixedLabelCommands/fixedLabelCommandsand theirremoveCommandForforms — has a table row indocs/commands.md;/commandrow indocs/commands.mdis implemented (the/<key>placeholders are skipped);/override,/skip,/retest-requiredremain listed as unsupported with neither a row nor a handler;prow-commandsdefault of.github/workflows/prow.ymlequals exactly handlers-minus-/meowplus the label commands, making the "every built-in command except /meow" description an asserted equality.Mutation-checked: renaming one doc row fails both inclusion tests.
npx vitest run __tests__/commands.test.tsandnpx eslint __tests__/commands.test.tspass onmain@ c48bd6d.Cluster:
docs/commands.md↔handleIssueComment.ts/labels/{fixed,prefixed}.ts/prow.ymlinput default. Disjoint from #232 (__tests__/workflows.test.ts, action.yml inputs) and #234 (__tests__/runtime.test.ts).Related Issue
Closes #253
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88