Repository navigation
test: assert .github/prow.yaml parses and agrees with prow-bot.yml, the label catalogue and the issue templates - #256
Merged
Conversation
…he label catalogue and the issue templates templates/prow.yaml is parse-tested; the repository's own bot configuration was not. Adds __tests__/dogfoodConfig.test.ts covering precedence, enabled commands, catalogue colours, the require_matching_label rule and its missing_comment, tide.merge_method and issue-template labels. Closes #255 Signed-off-by: quality <quality@hive.kubestellar.io>
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will automatically remove the |
Member
|
/kind cleanup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds
__tests__/dogfoodConfig.test.ts(new file only — disjoint from #232, which holds__tests__/workflows.test.ts, and from every other open PR). It parses the repository's live bot configuration.github/prow.yamlthe same wayworkflows.test.tsalready parsestemplates/prow.yaml, builds the catalogue withdesiredLabels, and asserts:require_matching_labelrule and atidegaterepoConfigPaths[0]and no other candidate path exists in the repository to shadow it/area /kind /priority /label /triage) is enabled inprow-bot.yml'sprow-commands, and every enabled built-in label command has a section or built-in values to allowbuiltinLabelDefaults; the catalogue carries every label the file namesregexpmatches a catalogued label, itsmissing_labelis catalogued (ededed), and each`/cmd value`inmissing_commentis an enabled command whose label satisfies the regexp and existstide.merge_methodis one ofmerge|squash|rebaselabels:front-matter entry in.github/ISSUE_TEMPLATE/*.md(currentlyarea/bug) is cataloguedVerified on
main@ c48bd6d, Node v26.10.0:npx vitest run __tests__/dogfoodConfig.test.ts→ 9/9 pass;npx eslint __tests__/dogfoodConfig.test.tsclean. Mutation check: changing the rule's regexp to^kid/and the comment to/kind cleanupsfails exactly the two rule tests. Nosrc/,dist/or workflow changes.Related Issue
Closes #255
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88