Skip to content

test: assert .github/prow.yaml parses and agrees with prow-bot.yml, the label catalogue and the issue templates - #256

Merged
github-actions[bot] merged 1 commit into
mainfrom
quality/test-dogfood-config
Oct 2, 2026
Merged

github-actions[bot] merged 1 commit into
mainfrom
quality/test-dogfood-config

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Test Improvement

Adds __tests__/dogfoodConfig.test.ts (new file only — disjoint from #232, which holds __tests__/workflows.test.ts, and from every other open PR). It parses the repository's live bot configuration .github/prow.yaml the same way workflows.test.ts already parses templates/prow.yaml, builds the catalogue with desiredLabels, and asserts:

  • it parses as the new form with label sections, a require_matching_label rule and a tide gate
  • it is repoConfigPaths[0] and no other candidate path exists in the repository to shadow it
  • every label section's command (/area /kind /priority /label /triage) is enabled in prow-bot.yml's prow-commands, and every enabled built-in label command has a section or built-in values to allow
  • colours/descriptions agree with builtinLabelDefaults; the catalogue carries every label the file names
  • each rule's regexp matches a catalogued label, its missing_label is catalogued (ededed), and each `/cmd value` in missing_comment is an enabled command whose label satisfies the regexp and exists
  • tide.merge_method is one of merge|squash|rebase
  • every labels: front-matter entry in .github/ISSUE_TEMPLATE/*.md (currently area/bug) is catalogued

Verified on main @ c48bd6d, Node v26.10.0: npx vitest run __tests__/dogfoodConfig.test.ts → 9/9 pass; npx eslint __tests__/dogfoodConfig.test.ts clean. Mutation check: changing the rule's regexp to ^kid/ and the comment to /kind cleanups fails exactly the two rule tests. No src/, dist/ or workflow changes.

Related Issue

Closes #255


Filed by quality agent (hold-gated mode). Human review required.

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

…he label catalogue and the issue templates

templates/prow.yaml is parse-tested; the repository's own bot
configuration was not. Adds __tests__/dogfoodConfig.test.ts covering
precedence, enabled commands, catalogue colours, the require_matching_label
rule and its missing_comment, tide.merge_method and issue-template labels.

Closes #255

Signed-off-by: quality <quality@hive.kubestellar.io>
@hivecommons-hive
hivecommons-hive Bot requested a review from jpmcb as a code owner October 1, 2026 05:25
@hivecommons-hive hivecommons-hive Bot added the hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the outreach agent is always held because it publishes project-facing communication.

Hive will automatically remove the hold label once current policy no longer requires a level hold for "quality". If this is an outreach PR, a human must review it and remove the label.

@jeefy

jeefy commented Oct 2, 2026

Copy link
Copy Markdown
Member

/kind cleanup
/lgtm
/approve
/hold cancel

@github-actions github-actions Bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 2, 2026
@github-actions github-actions Bot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-kind labels Oct 2, 2026
@github-actions
github-actions Bot merged commit 035afcb into main Oct 2, 2026
10 checks passed
@mrbobbytables
mrbobbytables deleted the quality/test-dogfood-config branch October 9, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[quality] .github/prow.yaml, the config prow-bot.yml runs with, is never parsed or validated by a test

1 participant