Skip to content

test(bundle): drive the status event's success path through dist/index.js as a row of the head-sha lookup case - #262

Merged
github-actions[bot] merged 1 commit into
mainfrom
quality/test-bundle-status-event
Oct 3, 2026
Merged

github-actions[bot] merged 1 commit into
mainfrom
quality/test-bundle-status-event

Conversation

@hivecommons-hive

@hivecommons-hive hivecommons-hive Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Test Improvement

Turns the existing check_suite completed without pull_requests: finds the pr by head sha case in __tests__/bundle/bundle.test.ts (tide describe) into an it.each(['check_suite', 'status']): the second row feeds a legacy commit-status payload ({ sha, state: 'success', context, repository }) through dist/index.js and asserts the same lookup-by-head-sha, merge and request sequence. That is the one status path the bundle suite did not reach; the no-open-pr, merge_on_events: false, missing-head-sha and ::debug:: text cases from the first revision were dropped on review (unit-covered at tide.test.ts:1000/1021/1042), along with the separate file and its copied helpers.

Net diff: +6/−2 in bundle.test.ts, no new file.

Verification on main @ a270568: npx eslint, npx tsc --noEmit, npx vitest run __tests__/bundle/bundle.test.ts -t "only a head sha" — both rows pass.

Related Issue

Closes #261


Filed by quality agent (hold-gated mode). Human review required.

@hivecommons-hive
hivecommons-hive Bot requested a review from jpmcb as a code owner October 1, 2026 15:52
@hivecommons-hive hivecommons-hive Bot added the hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the outreach agent is always held because it publishes project-facing communication.

Hive will automatically remove the hold label once current policy no longer requires a level hold for "quality". If this is an outreach PR, a human must review it and remove the label.

@jeefy jeefy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every case here is already unit-tested (tide.test.ts:1000/1021/1042). The status-success merge follows the same code path as the existing check_suite test at bundle.test.ts:1497; only the payload field differs.

  1. Keep only the status-success case, ideally as an it.each(['check_suite','status']) row on bundle.test.ts:1497.
  2. Drop the exact ::debug::tide: merge_on_events is false… text check.
  3. Don't copy the 10-path config-read list or expectRequests; share them (see the note about a shared __tests__/bundle/helpers.ts).

…x.js as a row of the head-sha lookup case

Signed-off-by: quality <quality@hive.kubestellar.io>
@hivecommons-hive
hivecommons-hive Bot force-pushed the quality/test-bundle-status-event branch from 99c26ff to 6cfd4bd Compare October 3, 2026 05:15
@hivecommons-hive hivecommons-hive Bot changed the title test(bundle): drive the status event's success path and the missing-head-sha arm through dist/index.js test(bundle): drive the status event's success path through dist/index.js as a row of the head-sha lookup case Oct 3, 2026
@hivecommons-hive hivecommons-hive Bot added agent/quality Created by Hive for agent-filed issue provenance hive/hosted-available-lke648397-260827-5q9t Created by Hive for agent-filed issue provenance labels Oct 3, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Addressed: statusEvent.test.ts is gone; the status-success case is now the second row of an it.each(['check_suite', 'status']) on the existing head-sha lookup test in bundle.test.ts (+6/−2). No ::debug:: text check, no copied helpers. Rebased on main @ a270568.


🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: 6cfd4bd

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

@jeefy

jeefy commented Oct 3, 2026

Copy link
Copy Markdown
Member

#273 is merged: __tests__/bundle/helpers.ts now exports repo, token, comment(), configReads(), ownersReads, ownersProbe, queueRead, membershipReads(), and via helpersFor(() => gh): calls(), expectRequests(), expectCommandThenConfig() and routeOwners(). Please rebase on main and import these instead of declaring local copies.

@jeefy jeefy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asks addressed, thanks.

@jeefy

jeefy commented Oct 3, 2026

Copy link
Copy Markdown
Member

/kind cleanup
/lgtm
/approve
/hold cancel

@github-actions github-actions Bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 3, 2026
@github-actions github-actions Bot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-kind labels Oct 3, 2026
@github-actions
github-actions Bot merged commit 669009f into main Oct 3, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent/quality Created by Hive for agent-filed issue provenance hive/hosted-available-lke648397-260827-5q9t Created by Hive for agent-filed issue provenance kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged.

Projects

None yet

1 participant