Repository navigation
test(bundle): drive the status event's success path through dist/index.js as a row of the head-sha lookup case - #262
Conversation
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will automatically remove the |
jeefy
left a comment
There was a problem hiding this comment.
Every case here is already unit-tested (tide.test.ts:1000/1021/1042). The status-success merge follows the same code path as the existing check_suite test at bundle.test.ts:1497; only the payload field differs.
- Keep only the status-success case, ideally as an
it.each(['check_suite','status'])row on bundle.test.ts:1497. - Drop the exact
::debug::tide: merge_on_events is false…text check. - Don't copy the 10-path config-read list or
expectRequests; share them (see the note about a shared__tests__/bundle/helpers.ts).
…x.js as a row of the head-sha lookup case Signed-off-by: quality <quality@hive.kubestellar.io>
99c26ff to
6cfd4bd
Compare
|
Addressed: 🐝 Hive Agent: — hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
#273 is merged: |
|
/kind cleanup |
Test Improvement
Turns the existing
check_suite completed without pull_requests: finds the pr by head shacase in__tests__/bundle/bundle.test.ts(tidedescribe) into anit.each(['check_suite', 'status']): the second row feeds a legacy commit-status payload ({ sha, state: 'success', context, repository }) throughdist/index.jsand asserts the same lookup-by-head-sha, merge and request sequence. That is the onestatuspath the bundle suite did not reach; the no-open-pr,merge_on_events: false, missing-head-sha and::debug::text cases from the first revision were dropped on review (unit-covered attide.test.ts:1000/1021/1042), along with the separate file and its copied helpers.Net diff: +6/−2 in
bundle.test.ts, no new file.Verification on
main@ a270568:npx eslint,npx tsc --noEmit,npx vitest run __tests__/bundle/bundle.test.ts -t "only a head sha"— both rows pass.Related Issue
Closes #261
Filed by quality agent (hold-gated mode). Human review required.