fix: name the cron and pull request dispatchers in their failure messages - #271
Merged
Merged
Conversation
Contributor
|
Please add a kind label with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
src/cronJobs/handleCronJob.tsandsrc/pullReq/handlePullReq.tsboth wrap their job results in:That prefix was copy-pasted from
src/issueComment/handleIssueComment.ts— but these are the cron-job and pull-request dispatchers, so failures in scheduled jobs and PR events are mislabeled as issue-comment failures.What changed
handleCronJob.ts:error handling cron job: …handlePullReq.ts:error handling pull request: …handleIssueComment.tsuntouched (it was already correct).handleIssueCommentpath (issue_commentevent or direct call), not the cron/PR dispatchers.dist/index.jsregenerated; only the two intended lines changed.Unblocks review feedback on #242 and #248.