test(bundle): drive the config input's explicit source and the loader's tier read failures through dist/index.js

[hivecommons-hive]

Test Improvement

Adds __tests__/bundle/explicitConfigSource.test.ts (new file only; imports comment, configReads, helpersFor, repo, token from ./helpers) — ten /kind cleanup runs through the committed dist/index.js against fakeGithub, the first bundle tests to set the config action input or to make a configuration read fail. Arms of src/utils/config.ts reached:

• loadExplicitTier (L236–266): cncf/prow-config:prow.yaml is read with github-token (GET /repos/cncf/prow-config/contents/prow.yaml) and neither .project nor .github org repo is probed; @v1.2 arrives as ?ref=v1.2; the repository's own .github/prow.yaml still layers over it (its kind: [bug] replaces the explicit list, so cleanup is refused with kind: command args missing from body); a 404 → could not load prow config from cncf/prow-config:prow.yaml: not found; a 500 → … HttpError: boom; http://… → config: http:// sources are not allowed, use https://; just-a-file.yaml → config: expected owner/repo:path[@ref] or an https:// url, got 'just-a-file.yaml'. The two refusals make no read of the explicit source.
• fetchRepoFile (L278–282): a directory listing for cncf/prow-config:configs → TypeError: configs is not a file.
• loadOrgTier / loadRepoTier (L206, L225): a 500 on .project/contents/prow.yaml fails with could not load organization prow config from Codertocat/.project:prow.yaml: HttpError: boom and never probes .github; a 500 on .github/prow.yaml fails with could not load prow config from Codertocat/Hello-World:.github/prow.yaml: HttpError: boom and never probes the next path.

Every failure case asserts exit 1, the could not get labels from yaml: Error: <cause> error annotation and no write to the API.

Measured with npm run test:coverage:e2e on main @ 3fc21f2: src/utils/config.ts e2e lines 69.12 % → 72.19 % (newly reached L206, 225, 247, 256, 259, 278, 282); all files 77.9 % → 78.32 % lines. Unit run unchanged: 81 files / 1649 tests pass; npx eslint and tsc --noEmit clean on the new file.

Not covered here, on purpose: fetchUrl (L290–301, the https:// source) needs a TLS server the fake GitHub does not provide and stays unit-only. Disjoint from #293, which reaches config.ts 353/365/519–527/592–612 (the normalizers).

Related Issue

Closes #313

---

Filed by quality agent (hold-gated mode). Human review required.

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the outreach agent is always held because it publishes project-facing communication.

Hive will keep the hold label until a human removes it. Operators can make a deliberate one-off release during an ACMM level change with release_level_holds=true, but level changes never release this hold automatically.

[jeefy]

Six of the ten cases add coverage. bundle.test.ts:2157 and :2178 already set the config input.

• Drop explicitConfigSource.test.ts:56 and :70. bundle.test.ts:2157 already runs config: 'Codertocat/shared-config:labels/prow.yaml@v1'.
• Drop :121 (the http:// row) and :103. bundle.test.ts:2178 covers the http:// rejection, and :103's lines are already reached by L111 and L131/L140.

[hivecommons-hive]

Addressed: dropped the two owner/repo:path happy-path cases (bundle.test.ts:2157 runs that input), the failed-read case and the http:// row. The layering case now expects #376's no allowed value in "cleanup" wording instead of command args missing. Merged main too (it brings #287's meow network fix, which is what build-test was failing on).

---

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: unknown

— hive: agent=quality backend=copilot model=claude-fable-5.1

[hivecommons-hive]

Addressed in 95da151: dropped the two cases bundle.test.ts:2157 already runs, the http:// row, and the case whose lines L111/L131/L140 already reach.

CI is green on the new head.

---

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: 1f7d33c

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

[jeefy]

All four drops are done. On current main one more case adds nothing:

• Drop explicitConfigSource.test.ts:48–59 (the repository tier layering over the explicit source). The explicit-source read (config.ts:283–308) is reached by bundle.test.ts:2148, and the no allowed value in refusal (prefixed.ts:251) by prefixedRemoveArms.test.ts:44, which merged in #341 after the first review.

[hivecommons-hive]

Addressed in 6885c00: dropped the repository-tier layering case (:48–59); config.ts:283–308 is reached by bundle.test.ts:2148 and prefixed.ts:251 by prefixedRemoveArms.test.ts:44 since #341. Five cases remain.

---

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: 6885c00

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

[mrbobbytables]

/kind cleanup