test(bundle): drive /hold cancel's no-label, failed-read, failed-removal and already-gone arms through dist/index.js

[hivecommons-hive]

Test Improvement

Adds __tests__/bundle/holdCancelArms.test.ts (new file only; imports comment, configReads, helpersFor, repo, token from ./helpers) — six cases run through the committed dist/index.js against fakeGithub, covering the cancelHold arms of src/labels/hold.ts that no bundle suite reached:

1. /hold cancel, /unhold, /remove-hold on an issue whose labels are [lgtm] → exit 0, no DELETE, requests are the config reads then GET /issues/1 (hold.ts L67–69).
2. /hold cancel with GET /issues/1 → 500 → exit 1, error carries could not get labels from issue, no DELETE (L60–61).
3. /hold cancel with DELETE …/labels/do-not-merge%2Fhold → 500 → exit 1, error carries both could not remove the hold label and the cause could not remove label do-not-merge/hold (L75–76).
4. /hold cancel with hold + do-not-merge/hold present, DELETE …/labels/hold → 404, the other → 200 → exit 0, both DELETEs sent (src/utils/labeling.ts L202–203, the benign gone-label arm).

Cluster: src/labels/hold.ts cancelHold + src/utils/labeling.ts removeLabels 404 arm. Disjoint from #293 (holdSweepSettings: configured hold.label, label present) and from bundle.test.ts's /unhold case (both labels present, writes accepted).

Measured with npm run test:coverage:e2e on main @ 3fc21f2, before → after: src/labels/hold.ts 80 % → 96 % lines, 81.81 % → 90.9 % branches; src/utils/labeling.ts 73.07 % → 76.92 % lines; bundle suite 142 → 148 tests. The remaining hold.ts line (L30, missing issue number) cannot be produced through the API.

Verified locally: npx vitest run __tests__/bundle/holdCancelArms.test.ts → 6 pass; npx eslint and npx tsc --noEmit clean.

Related Issue

Closes #325

---

Filed by quality agent (hold-gated mode). Human review required.

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the outreach agent is always held because it publishes project-facing communication.

Hive will keep the hold label until a human removes it. Operators can make a deliberate one-off release during an ACMM level change with release_level_holds=true, but level changes never release this hold automatically.

[jeefy]

• holdCancelArms.test.ts:27: reduce it.each(['/hold cancel', '/unhold', '/remove-hold']) to a single /hold cancel case. All three rows reach the same lines and branches (hold.ts:67–69), and the alias handling is already covered on main.

[hivecommons-hive]

Addressed: the it.each over /hold cancel, /unhold, /remove-hold is now a single /hold cancel case. Also merged main (picks up #287's meow network fix, which was what failed build-test here).

---

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: unknown

— hive: agent=quality backend=copilot model=claude-fable-5.1

[hivecommons-hive]

Addressed in 8a99d52: the it.each over the three spellings is reduced to a single /hold cancel case.

CI is green on the new head.

---

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: 1f7d33c

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

[jeefy]

Asks addressed; verified on current main (aa6a0f8) together with the other approved PRs.

[jeefy]

/kind cleanup
/lgtm
/approve
/hold cancel