Repository navigation
test(bundle): drive the OWNERS filters-ignored arm (owners.ts parseOwners) through dist/index.js - #365
Conversation
…ners) through dist/index.js __tests__/bundle/ownersFilters.test.ts serves one OWNERS blob with a top-level approver and a filters section naming another, and drives /approve through the bundle: the top-level approver still gets approved and the debug log notes the ignored filters; the filter-only login is refused with no label write. Closes #364 Signed-off-by: quality <quality@hive.kubestellar.io>
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will keep the |
jeefy
left a comment
There was a problem hiding this comment.
L49 alone reaches owners.ts:46. L61 reaches nothing new.
- Drop
ownersFilters.test.ts:61–74. The non-approver refusal is already covered at bundle.test.ts:629. Dropping it also removes the full comment-body pin at L73.
Signed-off-by: quality <quality@hive.kubestellar.io>
|
Addressed: dropped the filter-only approver refusal case (and its full comment-body pin). Merged 🐝 Hive Agent: — hive: agent=quality backend=copilot model=claude-fable-5.1 |
|
Addressed in 845a7a3: dropped the filter-only approver refusal case (and its full comment-body pin). CI is green on the new head. 🐝 Hive Agent: — hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
/kind cleanup |
Test Improvement
Adds
__tests__/bundle/ownersFilters.test.ts(one new file; no change tohelpers.ts,fakeGithub.ts,runBundle.tsor any existing test). It routes oneOWNERSblob —approvers: [alice]plus afilters: { '.*': { approvers: [bob] } }section — and drives/approvethrough the committeddist/index.jstwice:approvedlabel written, stdout carriesOWNERS at OWNERS: filters are not supported; ignoring— the arm atsrc/utils/owners.ts:46the bundle suite never reached.Cannot approve the pull request: Error: bob is not an approver for any changed file, no label write — the filter grants nothing, asdocs/prow-for-your-org.md:41/docs/commands.md:321promise.Evidence:
npm run test:coverage:e2eonmain@ 3fc21f2 merged with all 44 open held PR heads (#230..#363) leftowners.ts:46at 0 e2e hits; with this file it reportsDA:46,2. Unit coverage of the line was already 100 % (__tests__/utils/owners.test.ts). Both tests pass locally (Node v26.10.0, vitest 5.0.3);npx eslintclean.Cluster claimed:
src/utils/owners.tsparseOwnersfilters arm, via/approveon anissue_comment. Disjoint from the held OWNERS PRs (#283 root-OWNERS authorization, #320 truncated-tree probes, #328/#331 pullRequestOwners and issue-side fallback).Related Issue
Closes #364
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88