Repository navigation
test(bundle): drive the 'could not list the repository labels' arms of labelIssue and label-sync through dist/index.js - #388
Merged
Conversation
…f labelIssue and label-sync through dist/index.js Adds __tests__/bundle/labelListingRefused.test.ts, routing GET /labels to 500 so assertLabelsExist (src/utils/labeling.ts:135, via labelIssue) and labelSync (src/cronJobs/labelSync.ts:55) rethrow end-to-end, asserting the single failure annotation and that no write follows. Closes #387 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
hivecommons-hive
Bot
added
the
hold
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will keep the |
This was referenced Oct 8, 2026
Contributor
Author
|
/kind cleanup 🐝 Hive Agent: — hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
github-actions
Bot
added
kind/cleanup
Member
|
/kind cleanup |
github-actions
Bot
added
lgtm
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds
__tests__/bundle/labelListingRefused.test.ts(new file; nothing else touched), the first bundle test to make the repository label-catalog read (GET /repos/Codertocat/Hello-World/labels) fail, driving through the committeddist/index.jsagainst the fake GitHub API:/kind cleanupwithGET /labels→ 500 exits 1 with the single annotationerror handling issue comment: Error: could not list the repository labels: HttpError: boom, after the config reads and the one catalog read, with no write (src/utils/labeling.ts:135,assertLabelsExistvialabelIssue)jobs: label-synconworkflow_dispatchwith the same route exits 1 witherror handling cron job: Error: could not list the repository labels: HttpError: boom, with no POST or PATCH (src/cronJobs/labelSync.ts:55)Measured with
npm run test:coverage:e2eonmain@ aa6a0f8:labelSync.tsline 55 andlabeling.tsline 135 go from 0 hits to covered; on a scratch branch overlaying all 33 open hold-gated bundle PRs (#283 … #385) they were the onlycould not list the repository labelsstatements still at 0. Unit coverage of both files is already 100 %. The file passes against the committeddist/index.js(npx vitest run __tests__/bundle/labelListingRefused.test.ts);eslintandtsc --noEmitclean. Nosrc/,dist/or workflow changes.Cluster: label-catalog read failure — disjoint from #312 (
labelSyncFailureArms.test.ts: refused writes / description drift, which leaves line 55 uncovered by its own account) and fromlabelWriteRefused.test.ts(the/kindwrite refusal, which routes the catalog read to 200).Related Issue
Closes #387
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1