Repository navigation
test(bundle): drive the plugin payload guards (requireMatchingLabel.ts:184, blunderbuss.ts:94, trigger.ts:188, tide.ts:489) through dist/index.js - #399
Merged
Conversation
…s:184, blunderbuss.ts:94, trigger.ts:188, tide.ts:489) through dist/index.js Three cases, each reaching a guard no bundle test drives: an opened pull_request event without a pull_request object (require-matching-label and blunderbuss), a synchronize carrying ok-to-test but no head (trigger), and /lgtm on an issue_comment without an issue, whose post-command sweep reaches tide's guard after the command's own. Messages are checked by fragment. Closes #398 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
hivecommons-hive
Bot
added
the
hold
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will keep the |
1 task
Member
|
/kind cleanup |
github-actions
Bot
added
kind/cleanup
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds
__tests__/bundle/pluginPayloadGuards.test.tswith three cases, each reaching a guard no bundle test drives (verified undervitest.e2e-coverage.config.mjsonmain@ aa6a0f8: every line below goes from 0 to 1 hit):pull_requestopenedwith nopull_requestobjectrequireMatchingLabel.ts:184(missing issue or pull request) andblunderbuss.ts:94(missing pull request)pull_requestsynchronizecarryingok-to-testbut noheadtrigger.ts:188(missing pull request head)/lgtmon anissue_commentwith noissuetide.ts:489(missing issue), reached by the post-command sweep after the command's own number guardMessages are asserted by fragment (no
TypeError: … Error:wrapper, noJSON.stringifytail), and the first and third cases assert no API call was made.Disjoint from #343 (
missingNumberGuards.test.ts: the commands'issue.number/pull_request.numberguards andonPrLgtm); this file covers the plugin handlers' object-level guards only.Related Issue
Closes #398
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88