Repository navigation
test(bundle): drive blunderbuss's assignee exclusion (pullRequestOwners.ts:96) through dist/index.js - #403
Merged
Conversation
…rs.ts:96) through dist/index.js A pull request's assignees are read lowercased and kept out of blunderbuss's reviewer candidates, but no bundle test ever served a pull request with assignees, so the mapping and the exclusion had no end-to-end hits. Add the case to blunderbussSettings.test.ts: one of two reviewers assigned under a mixed-case login leaves the other requested; both assigned leaves nobody. Closes #402 Signed-off-by: quality <quality@hive.kubestellar.io>
hivecommons-hive
Bot
added
the
hold
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will keep the |
Contributor
|
Please add a kind label with |
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds an
it.eachto__tests__/bundle/blunderbussSettings.test.tsserving apull_request openedevent with a non-emptyassigneesarray on the pull request:sdk/reviewers assigned under a mixed-case login (Carol) → onlybobis requestedBOB,carol) → no request andblunderbuss: no reviewer candidates for #1This is the first bundle test to give
loadPullRequestOwnersassignees, sosrc/utils/pullRequestOwners.ts:96(the lowercasing map) and thepull.assigneesmember ofblunderbuss.ts:165's exclusion set go from 0 to 3 end-to-end hits (npm run test:coverage:e2e,coverage-final.jsonfnMap at line 96). Test-only; nosrc/ordist/change.Files:
__tests__/bundle/blunderbussSettings.test.tsonly. Does not overlap the open held bundle PRs (#298 … #401), none of which touch blunderbuss orpullRequestOwners.ts.Related Issue
Closes #402
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88