Repository navigation
fix(config): treat a comment-only prow.yaml as an empty configuration - #415
Merged
Merged
Conversation
yaml.load throws on zero-document input, which a file holding only
comments is. Check the document count first so it loads as {}.
Fixes cncf#393
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Bob Killen <bkillen@linuxfoundation.org>
Contributor
|
Please add a kind label with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
parseProwConfigonly short-circuited blank/whitespace input. A file holding only comments contains zero YAML documents, whichyaml.loadrejects withexpected a document, but the input is empty, breaking every configuration-reading command. The document count is now checked first, so a comment-only file loads as an all-empty configuration like a blank one.Fixes #393
Testing
treats %s as an all-empty configin__tests__/utils/config.test.tsnpm testThe bundle test for this arm is in #395, which can add the comment-only case to its
emptyDocumentstable once both land.Checklist
npm run allto lint and build my codenpm run packand committeddist/