Repository navigation
fix(owners): read a 0-byte OWNERS file as listing nobody - #416
Merged
Merged
Conversation
GitHub returns content "" for an empty blob; the truthiness check on content rejected it as invalid. Check for undefined instead so the empty file reaches parseOwners. Fixes cncf#404 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Bob Killen <bkillen@linuxfoundation.org>
Contributor
|
Please add a kind label with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GitHub returns
content: ""for an empty blob. Both OWNERS decode sites (decodeinsrc/utils/owners.ts,retrieveOwnersFileinsrc/utils/auth.ts) rejected that asinvalid OWNERS file returned from GitHub API, failing every OWNERS-reading run on a 0-byteOWNERSfile. They now only reject a missingcontent, so an empty file reachesparseOwnersand lists nobody.Fixes #404
Testing
__tests__/utils/ownersAuth.test.ts(tree/blob path)policyAllowstable in__tests__/utils/auth.test.tsnpm test#406 drives the other
parseOwnersshapes through the bundle; a 0-byte case can be added there now.Checklist
npm run allto lint and build my codenpm run packand committeddist/