Repository navigation
test(bundle): drive the prefixed label refusal's 'allowed: none' arm (prefixed.ts:251) through dist/index.js - #420
Merged
Conversation
…(prefixed.ts:251) through dist/index.js
normalizeSection accepts kind: [] and kind: { values: [] }, so a stubbed
section refuses every argument with 'allowed: none'; the only bundle fixture
of this refusal lists two allowed values, so the fallback never fired.
Closes #419
Signed-off-by: quality <quality@hive.kubestellar.io>
hivecommons-hive
Bot
added
the
hold
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will keep the |
Member
|
/kind cleanup |
github-actions
Bot
added
kind/cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds
__tests__/bundle/prefixedEmptyAllowlist.test.ts(2 tests) driving/kindthroughdist/index.jsagainst the fake GitHub with a.prowlabels.yamlwhosekindsection is present but empty —kind: []andkind: { values: [], exclusive: true }, both accepted bynormalizeSection. Each refuses withkind: no allowed value in "…"; allowed: none, exercising theallowed.join(', ') || 'none'fallback ofrequestedLabels(src/labels/prefixed.ts:251) after the config reads, with no label read or write.Files/functions claimed:
src/labels/prefixed.tsrequestedLabelsempty-allowlist arm only. Disjoint fromprefixedRemoveArms.test.ts(#341), which serves a populatedkindsection.Measured with
npm run test:coverage:e2eonmain@ 0328961:prefixed.tsbranch 251 covered. Test-only change: nosrc/ordist/edits.Related Issue
Closes #419
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88