Repository navigation
fix(meow): match /meow case-insensitively like every other command - #453
Merged
Merged
Conversation
docs/commands.md says commands are case-insensitive, and handleIssueComment dispatches /MEOW to the meow handler, but meow.ts re-checked the line with a case-sensitive pattern, so /MEOW and /Meow were silently dropped. Add the i flag and unit-test both spellings. Signed-off-by: Jeffrey Sica <me@jeefy.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/commands.mdsays commands are case-insensitive, andhandleIssueCommentdoes dispatch/MEOWto the meow handler. Butmeow.tsthen re-checks the line against its own case-sensitive pattern, so/MEOWand/Meowwere silently ignored. Found while reviewing #397.Fix: add the
iflag tomeowCommand(src/issueComment/meow.ts:12). The pattern still requires the line to be exactly/meow, so/meowvie,/meow catand mentions are still ignored.Tests: a new unit case for
/MEOWand/Meowposts the image; it fails on main and passes with the fix.dist/matches a freshnpm run pack.