Skip to content

test(bundle): drive fileList's and N more truncation (tide.ts:291) through dist/index.js - #476

Merged
mrbobbytables merged 1 commit into
mainfrom
quality/test-fork-workflows-file-list
Oct 15, 2026
Merged

mrbobbytables merged 1 commit into
mainfrom
quality/test-fork-workflows-file-list

Conversation

@hivecommons-hive

@hivecommons-hive hivecommons-hive Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Test Improvement

Adds one schedule lgtm case to the fork-workflows block of __tests__/bundle/pullRequestOwnersArms.test.ts, against a fork pull request GitHub refuses with 403, driven through dist/index.js:

  • the base is seven workflow files ahead (GET /compare/{head}...master, unsorted, with a duplicate and a non-workflow file): the posted <!-- prow-github-actions/fork-workflows: … --> comment and the ::warning:: name the first five sorted paths followed by and 2 more, omit f.yml/g.yml, and the request sequence is asserted in full

Claims only fileList / explainForkWorkflows in src/plugins/tide.ts (line 291); no production code changes. The unit suite already reaches the arm (tide.test.ts:465); this is its first dist/index.js run.

Related Issue

Refs #466

@hivecommons-hive
hivecommons-hive Bot requested a review from jpmcb as a code owner October 14, 2026 05:41
@hivecommons-hive hivecommons-hive Bot added the hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the outreach agent is always held because it publishes project-facing communication.

Hive will keep the hold label until a human removes it. Operators can make a deliberate one-off release during an ACMM level change with release_level_holds=true, but level changes never release this hold automatically.

@github-actions

Copy link
Copy Markdown
Contributor

Please add a kind label with /kind failing-test or /kind cleanup.

…through dist/index.js

The fork-workflows 403 diagnosis names at most five workflow files per
list; no bundle scenario had more than two, so tide.ts:291's truncation
arm was never reached end-to-end. One schedule lgtm case in
pullRequestOwnersArms' fork-workflows block now has the base seven
workflow files ahead (unsorted, with a duplicate and a non-workflow file):
the comment and warning name the first five sorted paths and `and 2 more`.

Refs #466

Co-authored-by: quality <quality@hive.kubestellar.io>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Bob Killen <bkillen@linuxfoundation.org>
@mrbobbytables
mrbobbytables force-pushed the quality/test-fork-workflows-file-list branch from bcb7fc2 to 03067d5 Compare October 14, 2026 13:27
@mrbobbytables

Copy link
Copy Markdown
Member

Review: both cases reach only tide.ts:291's truncation arm — fileList is the same function for the behind and own lists, and both of tide.ts:269/270's non-empty arms are already reached by pullRequestOwnersArms.test.ts on main. Dropped the own case; the behind case (which also pins dedup + sort before the cut, and the full request sequence) now lives in that file's fork-workflows block, whose routeForkPr/runCron/gateReads/evaluation/marker the new file copied verbatim. Rebased on main.

@mrbobbytables mrbobbytables removed the hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2026
@mrbobbytables
mrbobbytables merged commit ef53556 into main Oct 15, 2026
10 checks passed
@mrbobbytables
mrbobbytables deleted the quality/test-fork-workflows-file-list branch October 15, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant