Repository navigation
test(bundle): drive fileList's and N more truncation (tide.ts:291) through dist/index.js - #476
Conversation
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will keep the |
|
Please add a kind label with |
…through dist/index.js The fork-workflows 403 diagnosis names at most five workflow files per list; no bundle scenario had more than two, so tide.ts:291's truncation arm was never reached end-to-end. One schedule lgtm case in pullRequestOwnersArms' fork-workflows block now has the base seven workflow files ahead (unsorted, with a duplicate and a non-workflow file): the comment and warning name the first five sorted paths and `and 2 more`. Refs #466 Co-authored-by: quality <quality@hive.kubestellar.io> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Bob Killen <bkillen@linuxfoundation.org>
bcb7fc2 to
03067d5
Compare
|
Review: both cases reach only tide.ts:291's truncation arm — |
Test Improvement
Adds one
schedulelgtmcase to the fork-workflows block of__tests__/bundle/pullRequestOwnersArms.test.ts, against a fork pull request GitHub refuses with 403, driven throughdist/index.js:GET /compare/{head}...master, unsorted, with a duplicate and a non-workflow file): the posted<!-- prow-github-actions/fork-workflows: … -->comment and the::warning::name the first five sorted paths followed byand 2 more, omitf.yml/g.yml, and the request sequence is asserted in fullClaims only
fileList/explainForkWorkflowsinsrc/plugins/tide.ts(line 291); no production code changes. The unit suite already reaches the arm (tide.test.ts:465); this is its firstdist/index.jsrun.Related Issue
Refs #466