Detect the branch from the checkout, not the dispatch ref - #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third rehearsal finding:
workflow_dispatchruns on the repository's default branch, which during a transition is theN.xmaintenance branch by design — so the promote's branch assertion readGITHUB_REF_NAME=1.xand refused, even though the workflow's checkout correctly pinsmain. The cut and promote task scripts now read the branch from the actual checkout (git branch --show-current); the postversion guard keeps its env-first behaviour, which is correct in the push-triggered changesets-action context.