Repository navigation
feat(groups): Show Group Card on every invite link, and the host Invite sheet - #1912
Merged
Merged
Conversation
…t's Approve new members switch Show Group Card now sits next to Share and Copy for both the plain link and an invite link, and the invite sheet's pill shows the plain link the same way. The card encodes the link it was opened from; the link reaches it in memory (GroupCardLinks), never on the saved AppRoute.Menu.GroupCard route, since an invite link's fragment is the chat key's secret. The host's Invite sheet (spec frame 1m) replaces the bottom-bar message: one link card, an Approve new members switch kept per group and account, and Manage Invites. Spec: code-payments/flipcash-client-orchestrator#82, docs/specs/group-invites.md surface 1.
…e Figma's darker surfaces on it Share Link and Manage Invites return their pick through the nav result, as 2b does, so the next sheet opens once the host sheet is gone. The link card and both rows use white at 0.08 and the pill white at 0.06; the Invite People sheet keeps its pill color.
…eader and pill The link card's ⋯ menu is gone: Copy Link and Show Group Card are on the Invite People sheet that Share Link opens, and revoking is in Manage Invites. The host sheet's view model keeps only Share Link. The card now starts 16 below the header instead of touching its close button, and the pill is one 30-high line, 14 inside the card, as in Figma 1m. The row reads "Approve New Members", and its subtitles drop the "Off:" and "On:" prefixes.
…mbers toggles The pill's link, the caption under Share Link and the row's subtitle now fade between the off and on text over 220ms, and the card's height animates with them instead of jumping. The fades are plain tweens, so the system animation scale applies to them. The caption's top spacing moves into the caption, so a card with no caption still ends at the button.
iOS is now the reference for this card. The pill's link is Medium 14, and the caption under Share Link and both Approve New Members subtitles are Medium 13 at white 0.68. Both styles use the true Medium face (AvenirMedium); the theme's Avenir draws FontWeight.Medium as Demi. The Manage Invites subtitle keeps its shared style, as on iOS. The card fill (White08) and pill fill (0x0F, about 0.06) already matched, so they are unchanged.
Sheets shown through BottomBarManager with the DEFAULT type drew on bannerThemed (37,37,38), lighter than the navigation sheets, which draw on the theme background (25,25,26). iOS made the same change to PartialSheet's default. Sheets this changes, among the DEFAULT showMessage and bottomBarCardAction sheets: - Currency More (TokenInfoViewModel.presentMore) - Add Money start (InternalPurchaseMethodController.present) - Group money actions (ChatViewModel.presentMoneyActions) The host link card sheet and the E2EE learn-more sheet already drew on the background. ERROR, DESTRUCTIVE, INFO, WARNING and SUCCESS keep their banner colors.
Renames the tile's string (action_showGroupCard); the tile's icon has no content description, so the label is also what TalkBack reads. Class, file, resource and analytics names are unchanged.
The switch was already off when nothing is stored, but an IOException reading the DataStore ended the flow instead of answering. Unreadable preferences now read as empty, so the switch is off.
The 1m link card now uses iOS #1175's values: a 48dp capsule pill with the link 16dp from its ends, 20dp inside the card and 12dp between its items. The pill shows the whole link and cuts it in the middle, so the end of the token stays visible. Share Link stays the standard button. LinkPillFrame takes a shape and horizontal padding; their defaults keep the other pills as they were. The 1m preview uses a real-length invite link so its render shows the middle cut.
From iOS #1175's InvitePeopleSheet: the cards sit 12dp apart (8dp before), the link card starts 20dp under the header (16dp before) and the sheet ends 20dp under Manage Invites (16dp before). The header is still the shared AppBarWithTitle, so the gap is measured from the bottom of the bar.
1e's Share Group Link turned the switch on, from the host sheet and from the Invite People sheet. It now shares the plain /chat link once and leaves the switch as it was. Only the host's tap on the switch turns it on (spec #82, 02f6c77). InviteLinkViewModel no longer writes the switch, so it drops its ApproveNewMembersStore. InviteHostSheetViewModelTest covers 1e leaving the switch off and the host's tap turning it on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements surface 1 of
docs/specs/group-invites.mdfrom code-payments/flipcash-client-orchestrator#82 (built against 31dc181; that PR is still open).Invite People sheet. Both links now use the layout the invite link ships today: link pill, Share and Copy tiles, Recent Chats. The plain
/chatlink sits in the same pill without the "Expires · joined" line. Both links get a Show Group Card tile next to Share and Copy. Figma 1k's full-width rows are stale, so this follows the shipped sheet, not the frame.Host sheet (1m to 1m″). This replaces the
BottomBarManagerhost message with aChatStep.InviteHostsheet: the link card with its ⋯ menu (Copy Link, Show Group Card, Revoke and Make New Link), Approve new members, and Manage Invites. The Approve switch is stored per account and group inDataStoreApproveNewMembersStore. With it on, the card shows the plain link and Share Link opens the plain sheet. Share Link and Manage Invites return the pick as a nav result, and the screen beneath opens the next sheet once this one closes, the way 2b does. The card and rows use white at 0.08 and the pill white at 0.06, as 1m does; the Invite People pill keepsWhite05.1e's button now turns the switch on instead of opening the plain sheet.
Group card (1j). The invite URL reaches the card in memory:
GroupCardLinksholds it by chat id, andGroupCardViewModeltakes it and falls back to the plain link.AppRoute.Menu.GroupCardcarries only the chat id, andGroupCardRouteTestchecks that the serialized route contains no invite URL or#s=secret. For an invite URL the card shows "Scan to join" and the link's status under the QR.GroupCardQrTestdecodes an 82-byte invite link through the logo at level M.After process death the route restores without the in-memory link, so the card falls back to the plain link.
Tests:
DataStoreApproveNewMembersStoreTest,GroupCardLinksTest,GroupCardRouteTest,GroupCardQrTest, an updatedGroupCardTileTest(the tile shows for invite links),InviteLinkViewModelTest, and the 1m and 1m′ renders inInviteFramesScreenshotTest.Open: after Revoke and Make New Link, the card shows an empty pill and the next tap creates a link. No frame covers that state.