Repository navigation
feat(group-send): pick the currency on the confirm sheet only - #1916
Merged
Merged
Conversation
The group send amount step drops the currency pill, the "Enter up to" hint and the balance ceiling, and is titled "Total Amount To Send". Select People is titled "Split Between" and ends on Next. The confirm sheet is unchanged and is now the only balance check.
Checking You counts the sender in the split without paying them: the total is split between everyone checked in check order, then You's part is dropped. Only the other members are paid, Next needs at least one of them, and You does not count toward the 10 cap. Confirm lists only the paid members, and the balance check is against the sum of the paid parts.
Adds the youVectors from the shared group-send-split.json fixture and a GroupSendSplit.splitWithViewer that GroupSendState.plan uses, so the test and the app share the drop-You path. Fixes the delegate doc comment: the balance check is against the paid parts.
When the sender is in the split, the per-person line reads "$X each, including You" ("~" unless every part, the sender's included, is equal), and shows even for a single paid member. The You vectors now carry that label.
You's part is always the last share, so You never takes an extra cent, and the 10 People Max cap counts You: nine others plus You is the most. The Each strings are capitalized.
The bubble gets its own lowercase strings; only the confirm sheet's Each is capitalized.
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Group send no longer asks for a currency or checks a balance before the user has picked people. The currency is chosen on the confirm sheet, which is now the only place the balance is checked. Spec: code-payments/flipcash-client-orchestrator#84 (
docs/specs/group-send.md, Sender steps 1-3). There is no Figma frame for this change; it is removals and copy only.ChatAmountEntryContenttakes an optionaltitle; DM send passes none and keeps its pill and hint. The ceiling is dropped for group sends inmaxAmountFlow, andonConfirmRequestedskips the balance check for them (the send-limit check stays).titleandbuttonTextarguments. The request-money flow keeps its current title and button. Disabled-at-zero, the 10-max sheet and the too-small alert are unchanged.sendToMembers()checks the balance against the sum of the paid parts.sendToMembers()still shows the insufficient balance alert with Add Money when the total exceeds the picked token's balance.TokenCoordinatorandTokenSelectionResolverare untouched.Tests:
ChatGroupCashLinkTestgains tests for the You row ($30.00 between You and 2 others pays $10.00 twice and charges $20.00; $1.00 with You checked at any position pays $0.34 and $0.33 and You keeps $0.33; only You blocks Next; You plus 9 others is the most; the too-small check counts You), one test where a total above the balance passes the amount step and is stopped at confirm by the insufficient-balance alert, and one for no hint and a confirmable amount on the group amount step.