Repository navigation
feat(messenger): invite card in a new group's empty chat - #1927
Merged
Merged
Conversation
…roup ready card shows
…cs on the host sheet
…e the keyboard first
…t; preview empty groups as invite prompts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New groups now open on their chat instead of group info. While the viewer is the only member, the chat shows a card from Flipcash: "Your Group Is Ready / Invite people to join " with an Invite People button.
The card is a client-only transcript item built on
ShareProfileWidgetBubble, so it keeps the Share Profile look. It appears only in the chat; it is not stored or synced.When it shows
isGroup && memberCount == 1 && (canInvite || !isPrivate), once the roster has resolved. Creators of public groups havecan_invitefalse from the server but can still share the group, so!isPrivatecounts them in.Invite People
Opens the existing invite sheet (
inviteHost.presentHostSheet), after the keyboard hides.Keyboard.hideIfVisibleand its flat 300 ms delay are unchanged.When someone joins
The card fades out over 200 ms while its row collapses over 320 ms, so the conversation slides up into the space. The row stays in the list for the length of the animation.
Invite sheet
PaymentSuccessHoldDuration(1 s), then the full share sheet opens. An existing link opens it immediately.Chat list
A group row that would show "Nothing yet" and meets the card's condition shows "Invite people to get started". The copy is one string resource,
label_chat_preview_inviteToStart, and is not yet confirmed.