Repository navigation
fix(messenger): label paying a group request "Pay", not "Send" - #1928
Merged
Merged
Conversation
Request details' button now reads "Pay $20" (action_sendShare renamed to action_payShare), and the request pay sheet's swipe reads "Swipe to Pay". SwipePayUiState takes the swipe label, defaulting to "Swipe to Send", so group send, Currency Info send and the chat keep their copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paying your share of a group request read "Send $20" on Request details and "Swipe to Send" on the pay sheet. Both now say Pay.
action_sendShare("Send %1$s") becomesaction_payShare("Pay %1$s"). Request details was its only user, and it has no localized copies.SwipePayUiStategets aswipeLabelstring resource, defaulting toaction_swipeToSend. OnlyRequestPaySheetsets it, to the existingaction_swipeToPay. Group send, Currency Info send and the chat still read "Swipe to Send".RequestPayLabelTestchecks the request pay state resolves to "Swipe to Pay", a default state to "Swipe to Send", and the button to "Pay $20".Token and currency selection are unchanged.